[PR #1583] [MERGED] feat: group title and artist into one column #1790

Closed
opened 2026-02-26 03:32:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1583
Author: @phanan
Created: 11/12/2022
Status: Merged
Merged: 11/12/2022
Merged by: @phanan

Base: masterHead: feat/sorter


📝 Commits (1)

  • 5614779 feat: group title and artist into one column

📊 Changes

23 files changed (+345 additions, -132 deletions)

View changed files

📝 resources/assets/js/components/screens/AlbumScreen.vue (+1 -1)
📝 resources/assets/js/components/screens/AllSongsScreen.vue (+1 -1)
📝 resources/assets/js/components/screens/ArtistScreen.vue (+1 -1)
📝 resources/assets/js/components/screens/FavoritesScreen.vue (+1 -1)
📝 resources/assets/js/components/screens/GenreScreen.vue (+1 -1)
📝 resources/assets/js/components/screens/PlaylistScreen.vue (+2 -2)
📝 resources/assets/js/components/screens/QueueScreen.vue (+1 -1)
📝 resources/assets/js/components/screens/RecentlyPlayedScreen.vue (+1 -1)
📝 resources/assets/js/components/screens/search/SearchSongResultsScreen.vue (+2 -2)
📝 resources/assets/js/components/song/SongList.spec.ts (+26 -17)
📝 resources/assets/js/components/song/SongList.vue (+31 -64)
📝 resources/assets/js/components/song/SongListItem.spec.ts (+22 -17)
📝 resources/assets/js/components/song/SongListItem.vue (+29 -13)
resources/assets/js/components/song/SongListSorter.vue (+102 -0)
📝 resources/assets/js/components/song/__snapshots__/SongList.spec.ts.snap (+1 -1)
resources/assets/js/components/song/__snapshots__/SongListItem.spec.ts.snap (+3 -0)
📝 resources/assets/js/composables/index.ts (+1 -0)
resources/assets/js/composables/useFloatingUi.ts (+106 -0)
📝 resources/assets/js/composables/useSongList.ts (+8 -4)
📝 resources/assets/js/types.d.ts (+1 -3)

...and 3 more files

📄 Description

  • Group title and artist into one column
  • Create a "sorter" component
  • Simplify song list / song list item in the process

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1583 **Author:** [@phanan](https://github.com/phanan) **Created:** 11/12/2022 **Status:** ✅ Merged **Merged:** 11/12/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feat/sorter` --- ### 📝 Commits (1) - [`5614779`](https://github.com/koel/koel/commit/56147794aa9aa396f660c9f720ea5d6ca41343ab) feat: group title and artist into one column ### 📊 Changes **23 files changed** (+345 additions, -132 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/screens/AlbumScreen.vue` (+1 -1) 📝 `resources/assets/js/components/screens/AllSongsScreen.vue` (+1 -1) 📝 `resources/assets/js/components/screens/ArtistScreen.vue` (+1 -1) 📝 `resources/assets/js/components/screens/FavoritesScreen.vue` (+1 -1) 📝 `resources/assets/js/components/screens/GenreScreen.vue` (+1 -1) 📝 `resources/assets/js/components/screens/PlaylistScreen.vue` (+2 -2) 📝 `resources/assets/js/components/screens/QueueScreen.vue` (+1 -1) 📝 `resources/assets/js/components/screens/RecentlyPlayedScreen.vue` (+1 -1) 📝 `resources/assets/js/components/screens/search/SearchSongResultsScreen.vue` (+2 -2) 📝 `resources/assets/js/components/song/SongList.spec.ts` (+26 -17) 📝 `resources/assets/js/components/song/SongList.vue` (+31 -64) 📝 `resources/assets/js/components/song/SongListItem.spec.ts` (+22 -17) 📝 `resources/assets/js/components/song/SongListItem.vue` (+29 -13) ➕ `resources/assets/js/components/song/SongListSorter.vue` (+102 -0) 📝 `resources/assets/js/components/song/__snapshots__/SongList.spec.ts.snap` (+1 -1) ➕ `resources/assets/js/components/song/__snapshots__/SongListItem.spec.ts.snap` (+3 -0) 📝 `resources/assets/js/composables/index.ts` (+1 -0) ➕ `resources/assets/js/composables/useFloatingUi.ts` (+106 -0) 📝 `resources/assets/js/composables/useSongList.ts` (+8 -4) 📝 `resources/assets/js/types.d.ts` (+1 -3) _...and 3 more files_ </details> ### 📄 Description - [x] Group title and artist into one column - [x] Create a "sorter" component - [x] Simplify song list / song list item in the process --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1790
No description provided.