[PR #1570] [MERGED] chore: improve playback and related services #1782

New issue

Closed

opened 2026-02-26 03:32:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1570
Author: @phanan
Created: 10/30/2022
Status: ✅ Merged
Merged: 10/30/2022
Merged by: @phanan

Base: master ← Head: chore/playback-cleanup

📝 Commits (2)

391b317 chore: improve playback and related services
f584354 feat: simplify and revamp playback(-related) services

📊 Changes

19 files changed (+253 additions, -155 deletions)

View changed files

📝 resources/assets/js/App.vue (+3 -7)
📝 resources/assets/js/components/layout/app-footer/AudioPlayer.vue (+3 -1)
➕ resources/assets/js/components/layout/app-footer/index.spec.ts (+26 -0)
📝 resources/assets/js/components/layout/app-footer/index.vue (+26 -2)
📝 resources/assets/js/components/meta/SupportKoel.spec.ts (+5 -5)
📝 resources/assets/js/components/meta/SupportKoel.vue (+9 -14)
📝 resources/assets/js/components/ui/Volume.spec.ts (+20 -10)
📝 resources/assets/js/components/ui/Volume.vue (+11 -23)
➕ resources/assets/js/components/ui/__snapshots__/Volume.spec.ts.snap (+7 -0)
📝 resources/assets/js/config/events.ts (+0 -1)
📝 resources/assets/js/services/audioService.ts (+24 -6)
📝 resources/assets/js/services/index.ts (+1 -0)
📝 resources/assets/js/services/playbackService.spec.ts (+8 -16)
📝 resources/assets/js/services/playbackService.ts (+16 -57)
📝 resources/assets/js/services/socketListener.ts (+3 -3)
➕ resources/assets/js/services/volumeManager.spec.ts (+43 -0)
➕ resources/assets/js/services/volumeManager.ts (+35 -0)
📝 resources/assets/js/stores/preferenceStore.ts (+4 -1)
📝 resources/assets/js/utils/eventBus.spec.ts (+9 -9)

📄 Description

Refactor playback service
Extract volume management into its own module
Attempt to unlock audio context automatically
Get rid of KOEL_READY event and rely on reactivity instead.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1570 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/30/2022 **Status:** ✅ Merged **Merged:** 10/30/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `chore/playback-cleanup` --- ### 📝 Commits (2) - [`391b317`](https://github.com/koel/koel/commit/391b317672770287689486d751f1ff89eeb1ba97) chore: improve playback and related services - [`f584354`](https://github.com/koel/koel/commit/f584354df9adb3d9b4654ce839c0b6c72478c3eb) feat: simplify and revamp playback(-related) services ### 📊 Changes **19 files changed** (+253 additions, -155 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/App.vue` (+3 -7) 📝 `resources/assets/js/components/layout/app-footer/AudioPlayer.vue` (+3 -1) ➕ `resources/assets/js/components/layout/app-footer/index.spec.ts` (+26 -0) 📝 `resources/assets/js/components/layout/app-footer/index.vue` (+26 -2) 📝 `resources/assets/js/components/meta/SupportKoel.spec.ts` (+5 -5) 📝 `resources/assets/js/components/meta/SupportKoel.vue` (+9 -14) 📝 `resources/assets/js/components/ui/Volume.spec.ts` (+20 -10) 📝 `resources/assets/js/components/ui/Volume.vue` (+11 -23) ➕ `resources/assets/js/components/ui/__snapshots__/Volume.spec.ts.snap` (+7 -0) 📝 `resources/assets/js/config/events.ts` (+0 -1) 📝 `resources/assets/js/services/audioService.ts` (+24 -6) 📝 `resources/assets/js/services/index.ts` (+1 -0) 📝 `resources/assets/js/services/playbackService.spec.ts` (+8 -16) 📝 `resources/assets/js/services/playbackService.ts` (+16 -57) 📝 `resources/assets/js/services/socketListener.ts` (+3 -3) ➕ `resources/assets/js/services/volumeManager.spec.ts` (+43 -0) ➕ `resources/assets/js/services/volumeManager.ts` (+35 -0) 📝 `resources/assets/js/stores/preferenceStore.ts` (+4 -1) 📝 `resources/assets/js/utils/eventBus.spec.ts` (+9 -9) </details> ### 📄 Description - Refactor playback service - Extract volume management into its own module - Attempt to unlock audio context automatically - Get rid of `KOEL_READY` event and rely on reactivity instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:17 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:37 +03:00

[PR #1782] [MERGED] fix: broken pgsql query with distinct() #1872

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1782

No description provided.

Rows
Columns