[PR #1563] [MERGED] feat: use Dialog element for modals #1778

New issue

Closed

opened 2026-02-26 03:32:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1563
Author: @phanan
Created: 10/27/2022
Status: ✅ Merged
Merged: 10/27/2022
Merged by: @phanan

Base: master ← Head: feat/modal

📝 Commits (1)

3b2390b feat: use Dialog element for modals

📊 Changes

7 files changed (+81 additions, -74 deletions)

View changed files

📝 resources/assets/js/__tests__/setup.ts (+4 -0)
📝 resources/assets/js/components/layout/ModalWrapper.spec.ts (+1 -1)
📝 resources/assets/js/components/layout/ModalWrapper.vue (+61 -65)
📝 resources/assets/js/components/meta/AboutKoelModal.vue (+2 -5)
📝 resources/assets/js/components/meta/__snapshots__/AboutKoelModal.spec.ts.snap (+1 -1)
📝 resources/assets/js/components/song/EditSongForm.vue (+2 -2)
📝 resources/assets/sass/partials/_shared.scss (+10 -0)

📄 Description

Use HTML Dialog element for modals for better accessibility.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1563 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/27/2022 **Status:** ✅ Merged **Merged:** 10/27/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feat/modal` --- ### 📝 Commits (1) - [`3b2390b`](https://github.com/koel/koel/commit/3b2390baba5a8e656eb77a66b305bc5ac9b3b477) feat: use Dialog element for modals ### 📊 Changes **7 files changed** (+81 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/__tests__/setup.ts` (+4 -0) 📝 `resources/assets/js/components/layout/ModalWrapper.spec.ts` (+1 -1) 📝 `resources/assets/js/components/layout/ModalWrapper.vue` (+61 -65) 📝 `resources/assets/js/components/meta/AboutKoelModal.vue` (+2 -5) 📝 `resources/assets/js/components/meta/__snapshots__/AboutKoelModal.spec.ts.snap` (+1 -1) 📝 `resources/assets/js/components/song/EditSongForm.vue` (+2 -2) 📝 `resources/assets/sass/partials/_shared.scss` (+10 -0) </details> ### 📄 Description Use HTML Dialog element for modals for better accessibility. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:16 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1778

No description provided.

Rows
Columns