[PR #1560] [MERGED] chore: make GlobalEventListener renderless #1775

Closed
opened 2026-02-26 03:32:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1560
Author: @phanan
Created: 10/27/2022
Status: Merged
Merged: 10/27/2022
Merged by: @phanan

Base: masterHead: chore/global-ev-lstnr-renderless


📝 Commits (1)

  • e43030a chore: make GlobalEventListener renderless

📊 Changes

7 files changed (+56 additions, -54 deletions)

View changed files

📝 resources/assets/js/App.vue (+1 -1)
📝 resources/assets/js/components/layout/main-wrapper/ExtraPanel.spec.ts (+1 -1)
📝 resources/assets/js/components/screens/GenreScreen.spec.ts (+2 -2)
📝 resources/assets/js/components/ui/FooterPlayButton.spec.ts (+5 -5)
resources/assets/js/components/utils/GlobalEventListeners.ts (+46 -0)
resources/assets/js/components/utils/GlobalEventListeners.vue (+0 -44)
📝 resources/assets/js/directives/tooltip.ts (+1 -1)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1560 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/27/2022 **Status:** ✅ Merged **Merged:** 10/27/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `chore/global-ev-lstnr-renderless` --- ### 📝 Commits (1) - [`e43030a`](https://github.com/koel/koel/commit/e43030abffc9d29012bf3e06b665bf6fa726ff2b) chore: make GlobalEventListener renderless ### 📊 Changes **7 files changed** (+56 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/App.vue` (+1 -1) 📝 `resources/assets/js/components/layout/main-wrapper/ExtraPanel.spec.ts` (+1 -1) 📝 `resources/assets/js/components/screens/GenreScreen.spec.ts` (+2 -2) 📝 `resources/assets/js/components/ui/FooterPlayButton.spec.ts` (+5 -5) ➕ `resources/assets/js/components/utils/GlobalEventListeners.ts` (+46 -0) ➖ `resources/assets/js/components/utils/GlobalEventListeners.vue` (+0 -44) 📝 `resources/assets/js/directives/tooltip.ts` (+1 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1775
No description provided.