[PR #1526] [MERGED] fix(compilation): some bugs with album artists #1749

New issue

Closed

opened 2026-02-26 03:32:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1526
Author: @phanan
Created: 10/12/2022
Status: ✅ Merged
Merged: 10/12/2022
Merged by: @phanan

Base: master ← Head: fix/album-artist

📝 Commits (3)

3ec65c4 fix(compilation): some bugs with album artists
ad1d360 feat: greatly reduce artist/album query complexity
1acff99 feat: improve song updating logic

📊 Changes

42 files changed (+217 additions, -390 deletions)

View changed files

📝 app/Builders/AlbumBuilder.php (+0 -18)
📝 app/Builders/ArtistBuilder.php (+0 -21)
📝 app/Facades/Download.php (+1 -1)
📝 app/Http/Controllers/API/SongController.php (+2 -6)
📝 app/Http/Controllers/V6/API/AlbumController.php (+3 -6)
📝 app/Http/Controllers/V6/API/ArtistController.php (+3 -6)
📝 app/Http/Controllers/V6/API/QueueController.php (+1 -1)
📝 app/Http/Resources/AlbumResource.php (+0 -3)
📝 app/Http/Resources/ArtistResource.php (+0 -4)
📝 app/Http/Resources/SongResource.php (+2 -2)
📝 app/Models/Artist.php (+1 -0)
📝 app/Models/Song.php (+6 -0)
📝 app/Repositories/AlbumRepository.php (+17 -17)
📝 app/Repositories/ArtistRepository.php (+16 -14)
📝 app/Repositories/SongRepository.php (+1 -0)
📝 app/Services/DownloadService.php (+11 -5)
📝 app/Services/SmartPlaylistService.php (+2 -3)
📝 app/Services/SongService.php (+29 -52)
📝 app/Services/V6/SearchService.php (+2 -8)
📝 resources/assets/js/__tests__/factory/albumFactory.ts (+0 -5)

...and 22 more files

📄 Description

album artists not properly shown on Artist screen
updating song with album artists creates multiple albums
downloading artists doesn't cater for "album artist" songs
simplifies song updating logic

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1526 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/12/2022 **Status:** ✅ Merged **Merged:** 10/12/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fix/album-artist` --- ### 📝 Commits (3) - [`3ec65c4`](https://github.com/koel/koel/commit/3ec65c4197be722647449d9901b9c154cf9fcae4) fix(compilation): some bugs with album artists - [`ad1d360`](https://github.com/koel/koel/commit/ad1d36085a89311a17156cea70fb7518703e15f9) feat: greatly reduce artist/album query complexity - [`1acff99`](https://github.com/koel/koel/commit/1acff99fba67a07cefe7ee10c40cf683b536de25) feat: improve song updating logic ### 📊 Changes **42 files changed** (+217 additions, -390 deletions) <details> <summary>View changed files</summary> 📝 `app/Builders/AlbumBuilder.php` (+0 -18) 📝 `app/Builders/ArtistBuilder.php` (+0 -21) 📝 `app/Facades/Download.php` (+1 -1) 📝 `app/Http/Controllers/API/SongController.php` (+2 -6) 📝 `app/Http/Controllers/V6/API/AlbumController.php` (+3 -6) 📝 `app/Http/Controllers/V6/API/ArtistController.php` (+3 -6) 📝 `app/Http/Controllers/V6/API/QueueController.php` (+1 -1) 📝 `app/Http/Resources/AlbumResource.php` (+0 -3) 📝 `app/Http/Resources/ArtistResource.php` (+0 -4) 📝 `app/Http/Resources/SongResource.php` (+2 -2) 📝 `app/Models/Artist.php` (+1 -0) 📝 `app/Models/Song.php` (+6 -0) 📝 `app/Repositories/AlbumRepository.php` (+17 -17) 📝 `app/Repositories/ArtistRepository.php` (+16 -14) 📝 `app/Repositories/SongRepository.php` (+1 -0) 📝 `app/Services/DownloadService.php` (+11 -5) 📝 `app/Services/SmartPlaylistService.php` (+2 -3) 📝 `app/Services/SongService.php` (+29 -52) 📝 `app/Services/V6/SearchService.php` (+2 -8) 📝 `resources/assets/js/__tests__/factory/albumFactory.ts` (+0 -5) _...and 22 more files_ </details> ### 📄 Description - [x] album artists not properly shown on Artist screen - [x] updating song with album artists creates multiple albums - [x] downloading artists doesn't cater for "album artist" songs - [x] simplifies song updating logic --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:09 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:36 +03:00

[PR #1749] [CLOSED] chore(deps): bump es5-ext from 0.10.62 to 0.10.64 #1865

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1749

No description provided.

Rows
Columns