[PR #1515] [MERGED] fix: do not lazy-load GlobalEventListeners #1738

Closed
opened 2026-02-26 03:32:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1515
Author: @phanan
Created: 10/7/2022
Status: Merged
Merged: 10/7/2022
Merged by: @phanan

Base: masterHead: fix/global-event


📝 Commits (4)

  • 1c6159f fix: do not lazy-load GlobalEventListeners
  • 52083bb Merge branch 'master' of github.com:koel/koel into master
  • e4506de fix: direct playing from album track listing
  • 846946e chore: remove empty line

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 resources/assets/js/App.vue (+4 -2)

📄 Description

Lazyloading GlobalEventListeners may cause LOG_OUT event to not be listened to and handled properly.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1515 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/7/2022 **Status:** ✅ Merged **Merged:** 10/7/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fix/global-event` --- ### 📝 Commits (4) - [`1c6159f`](https://github.com/koel/koel/commit/1c6159f29ae386c4e9dbaf98e428218e4905e034) fix: do not lazy-load GlobalEventListeners - [`52083bb`](https://github.com/koel/koel/commit/52083bbe34c37416175ce825675f7953fd0cf07c) Merge branch 'master' of github.com:koel/koel into master - [`e4506de`](https://github.com/koel/koel/commit/e4506deb2b5326a96de377f2be5aecfef4ddfbe7) fix: direct playing from album track listing - [`846946e`](https://github.com/koel/koel/commit/846946e15e622b03f2ddcac27d206f5bcc0f89ab) chore: remove empty line ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/App.vue` (+4 -2) </details> ### 📄 Description Lazyloading GlobalEventListeners may cause `LOG_OUT` event to not be listened to and handled properly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1738
No description provided.