mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[PR #1515] [MERGED] fix: do not lazy-load GlobalEventListeners #1738
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1738
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1515
Author: @phanan
Created: 10/7/2022
Status: ✅ Merged
Merged: 10/7/2022
Merged by: @phanan
Base:
master← Head:fix/global-event📝 Commits (4)
1c6159ffix: do not lazy-load GlobalEventListeners52083bbMerge branch 'master' of github.com:koel/koel into mastere4506defix: direct playing from album track listing846946echore: remove empty line📊 Changes
1 file changed (+4 additions, -2 deletions)
View changed files
📝
resources/assets/js/App.vue(+4 -2)📄 Description
Lazyloading GlobalEventListeners may cause
LOG_OUTevent to not be listened to and handled properly.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.