[PR #1512] [MERGED] chore: improve assertEquals #1736

New issue

Closed

opened 2026-02-26 03:32:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1512
Author: @peter279k
Created: 10/1/2022
Status: ✅ Merged
Merged: 10/7/2022
Merged by: @phanan

Base: master ← Head: improve_assert_equals

📝 Commits (1)

d3ddbef Improve assertEquals

📊 Changes

17 files changed (+43 additions, -43 deletions)

View changed files

📝 tests/Feature/LastfmTest.php (+2 -2)
📝 tests/Feature/ObjectStorage/S3Test.php (+1 -1)
📝 tests/Feature/SettingTest.php (+1 -1)
📝 tests/Feature/SongTest.php (+15 -15)
📝 tests/Feature/V6/PlayCountTest.php (+2 -2)
📝 tests/Integration/Models/SongZipArchiveTest.php (+5 -5)
📝 tests/Integration/Services/ApplicationInformationServiceTest.php (+1 -1)
📝 tests/Integration/Services/InteractionServiceTest.php (+1 -1)
📝 tests/Integration/Services/MediaSyncServiceTest.php (+1 -1)
📝 tests/Unit/ApplicationTest.php (+4 -4)
📝 tests/Unit/Models/AlbumTest.php (+1 -1)
📝 tests/Unit/Models/SettingTest.php (+1 -1)
📝 tests/Unit/Models/SongTest.php (+1 -1)
📝 tests/Unit/Services/ApiClients/ApiClientTest.php (+3 -3)
📝 tests/Unit/Services/ApiClients/LastfmClientTest.php (+1 -1)
📝 tests/Unit/Services/MediaMetadataServiceTest.php (+2 -2)
📝 tests/Unit/Services/YouTubeServiceTest.php (+1 -1)

📄 Description

Changed log

It should use the assertSame to make assert equals strict.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1512 **Author:** [@peter279k](https://github.com/peter279k) **Created:** 10/1/2022 **Status:** ✅ Merged **Merged:** 10/7/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `improve_assert_equals` --- ### 📝 Commits (1) - [`d3ddbef`](https://github.com/koel/koel/commit/d3ddbefd0f14aea1487b8e933ed63be92c2844d4) Improve assertEquals ### 📊 Changes **17 files changed** (+43 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `tests/Feature/LastfmTest.php` (+2 -2) 📝 `tests/Feature/ObjectStorage/S3Test.php` (+1 -1) 📝 `tests/Feature/SettingTest.php` (+1 -1) 📝 `tests/Feature/SongTest.php` (+15 -15) 📝 `tests/Feature/V6/PlayCountTest.php` (+2 -2) 📝 `tests/Integration/Models/SongZipArchiveTest.php` (+5 -5) 📝 `tests/Integration/Services/ApplicationInformationServiceTest.php` (+1 -1) 📝 `tests/Integration/Services/InteractionServiceTest.php` (+1 -1) 📝 `tests/Integration/Services/MediaSyncServiceTest.php` (+1 -1) 📝 `tests/Unit/ApplicationTest.php` (+4 -4) 📝 `tests/Unit/Models/AlbumTest.php` (+1 -1) 📝 `tests/Unit/Models/SettingTest.php` (+1 -1) 📝 `tests/Unit/Models/SongTest.php` (+1 -1) 📝 `tests/Unit/Services/ApiClients/ApiClientTest.php` (+3 -3) 📝 `tests/Unit/Services/ApiClients/LastfmClientTest.php` (+1 -1) 📝 `tests/Unit/Services/MediaMetadataServiceTest.php` (+2 -2) 📝 `tests/Unit/Services/YouTubeServiceTest.php` (+1 -1) </details> ### 📄 Description # Changed log - It should use the `assertSame` to make assert equals strict. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:07 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1736

No description provided.

Rows
Columns