mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1735
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1509
Author: @phanan
Created: 9/23/2022
Status: ✅ Merged
Merged: 9/23/2022
Merged by: @phanan
Base:
master← Head:feat/1503-more-tags📝 Commits (2)
4b14930feat: support genre and year (closes #1503)924040ffix broken tests📊 Changes
22 files changed (+812 additions, -84 deletions)
View changed files
➕
app/Console/Commands/CollectTagsCommand.php(+53 -0)📝
app/Console/Commands/SyncCommand.php(+6 -2)📝
app/Http/Resources/SongResource.php(+2 -0)📝
app/Models/Song.php(+2 -0)📝
app/Services/FileSynchronizer.php(+1 -1)📝
app/Services/SongService.php(+6 -2)📝
app/Values/SmartPlaylistRule.php(+4 -2)📝
app/Values/SongScanInformation.php(+8 -2)📝
app/Values/SongUpdateData.php(+10 -0)📝
database/factories/SongFactory.php(+3 -0)➕
database/migrations/2022_09_21_084050_more_tags.php(+16 -0)📝
resources/assets/js/__tests__/factory/songFactory.ts(+3 -0)📝
resources/assets/js/components/song/EditSongForm.spec.ts(+12 -3)📝
resources/assets/js/components/song/EditSongForm.vue(+78 -48)📝
resources/assets/js/components/song/__snapshots__/EditSongForm.spec.ts.snap(+398 -12)➕
resources/assets/js/config/genres.ts(+193 -0)📝
resources/assets/js/config/index.ts(+1 -0)📝
resources/assets/js/config/smart-playlist/models.ts(+9 -10)📝
resources/assets/js/stores/songStore.ts(+2 -0)📝
resources/assets/js/types.d.ts(+3 -1)...and 2 more files
📄 Description
This PR adds support for genre and year ID tags. In order to collect these tags, a command needs to be executed:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.