[PR #1509] [MERGED] feat: support genre and year (closes #1503) #1735

Closed
opened 2026-02-26 03:32:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1509
Author: @phanan
Created: 9/23/2022
Status: Merged
Merged: 9/23/2022
Merged by: @phanan

Base: masterHead: feat/1503-more-tags


📝 Commits (2)

📊 Changes

22 files changed (+812 additions, -84 deletions)

View changed files

app/Console/Commands/CollectTagsCommand.php (+53 -0)
📝 app/Console/Commands/SyncCommand.php (+6 -2)
📝 app/Http/Resources/SongResource.php (+2 -0)
📝 app/Models/Song.php (+2 -0)
📝 app/Services/FileSynchronizer.php (+1 -1)
📝 app/Services/SongService.php (+6 -2)
📝 app/Values/SmartPlaylistRule.php (+4 -2)
📝 app/Values/SongScanInformation.php (+8 -2)
📝 app/Values/SongUpdateData.php (+10 -0)
📝 database/factories/SongFactory.php (+3 -0)
database/migrations/2022_09_21_084050_more_tags.php (+16 -0)
📝 resources/assets/js/__tests__/factory/songFactory.ts (+3 -0)
📝 resources/assets/js/components/song/EditSongForm.spec.ts (+12 -3)
📝 resources/assets/js/components/song/EditSongForm.vue (+78 -48)
📝 resources/assets/js/components/song/__snapshots__/EditSongForm.spec.ts.snap (+398 -12)
resources/assets/js/config/genres.ts (+193 -0)
📝 resources/assets/js/config/index.ts (+1 -0)
📝 resources/assets/js/config/smart-playlist/models.ts (+9 -10)
📝 resources/assets/js/stores/songStore.ts (+2 -0)
📝 resources/assets/js/types.d.ts (+3 -1)

...and 2 more files

📄 Description

This PR adds support for genre and year ID tags. In order to collect these tags, a command needs to be executed:

php artisan koel:tags:collect year genre
  • DB migration
  • Command to collect additional tags
  • Support in smart playlists
  • Make genre and year editable

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1509 **Author:** [@phanan](https://github.com/phanan) **Created:** 9/23/2022 **Status:** ✅ Merged **Merged:** 9/23/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feat/1503-more-tags` --- ### 📝 Commits (2) - [`4b14930`](https://github.com/koel/koel/commit/4b14930e23796c0596faa0a0b0a42a64cd784f84) feat: support genre and year (closes #1503) - [`924040f`](https://github.com/koel/koel/commit/924040f05db5884ade72f55b832d8adef3373666) fix broken tests ### 📊 Changes **22 files changed** (+812 additions, -84 deletions) <details> <summary>View changed files</summary> ➕ `app/Console/Commands/CollectTagsCommand.php` (+53 -0) 📝 `app/Console/Commands/SyncCommand.php` (+6 -2) 📝 `app/Http/Resources/SongResource.php` (+2 -0) 📝 `app/Models/Song.php` (+2 -0) 📝 `app/Services/FileSynchronizer.php` (+1 -1) 📝 `app/Services/SongService.php` (+6 -2) 📝 `app/Values/SmartPlaylistRule.php` (+4 -2) 📝 `app/Values/SongScanInformation.php` (+8 -2) 📝 `app/Values/SongUpdateData.php` (+10 -0) 📝 `database/factories/SongFactory.php` (+3 -0) ➕ `database/migrations/2022_09_21_084050_more_tags.php` (+16 -0) 📝 `resources/assets/js/__tests__/factory/songFactory.ts` (+3 -0) 📝 `resources/assets/js/components/song/EditSongForm.spec.ts` (+12 -3) 📝 `resources/assets/js/components/song/EditSongForm.vue` (+78 -48) 📝 `resources/assets/js/components/song/__snapshots__/EditSongForm.spec.ts.snap` (+398 -12) ➕ `resources/assets/js/config/genres.ts` (+193 -0) 📝 `resources/assets/js/config/index.ts` (+1 -0) 📝 `resources/assets/js/config/smart-playlist/models.ts` (+9 -10) 📝 `resources/assets/js/stores/songStore.ts` (+2 -0) 📝 `resources/assets/js/types.d.ts` (+3 -1) _...and 2 more files_ </details> ### 📄 Description This PR adds support for genre and year ID tags. In order to collect these tags, a command needs to be executed: ```bash php artisan koel:tags:collect year genre ``` - [x] DB migration - [x] Command to collect additional tags - [x] Support in smart playlists - [x] Make genre and year editable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1735
No description provided.