[PR #1502] [MERGED] feat: read LRC files if applicable (closes #1447) #1733

New issue

Closed

opened 2026-02-26 03:32:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1502
Author: @phanan
Created: 9/14/2022
Status: ✅ Merged
Merged: 9/14/2022
Merged by: @phanan

Base: master ← Head: feat/lrc

📝 Commits (1)

d291cff feat: read LRC file if applicable (closes #1447)

📊 Changes

13 files changed (+118 additions, -14 deletions)

View changed files

📝 .github/workflows/unit-backend.yml (+0 -6)
📝 .github/workflows/unit-frontend.yml (+0 -1)
📝 app/Http/Requests/API/PlaylistUpdateRequest.php (+1 -1)
📝 app/Models/Song.php (+7 -2)
📝 app/Services/FileSynchronizer.php (+9 -1)
➕ app/Services/SimpleLrcReader.php (+32 -0)
📝 resources/assets/js/__tests__/UnitTestCase.ts (+1 -0)
📝 resources/assets/js/components/song/SongContextMenu.spec.ts (+1 -1)
📝 resources/assets/js/stores/preferenceStore.ts (+1 -1)
📝 tests/Integration/Services/FileSynchronizerTest.php (+25 -1)
📝 tests/Unit/Models/SongTest.php (+8 -0)
➕ tests/Unit/Services/SimpleLrcReaderTest.php (+30 -0)
➕ tests/blobs/simple.lrc (+3 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1502 **Author:** [@phanan](https://github.com/phanan) **Created:** 9/14/2022 **Status:** ✅ Merged **Merged:** 9/14/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feat/lrc` --- ### 📝 Commits (1) - [`d291cff`](https://github.com/koel/koel/commit/d291cff90992d6b644bb581dba3d6da342dd1394) feat: read LRC file if applicable (closes #1447) ### 📊 Changes **13 files changed** (+118 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/unit-backend.yml` (+0 -6) 📝 `.github/workflows/unit-frontend.yml` (+0 -1) 📝 `app/Http/Requests/API/PlaylistUpdateRequest.php` (+1 -1) 📝 `app/Models/Song.php` (+7 -2) 📝 `app/Services/FileSynchronizer.php` (+9 -1) ➕ `app/Services/SimpleLrcReader.php` (+32 -0) 📝 `resources/assets/js/__tests__/UnitTestCase.ts` (+1 -0) 📝 `resources/assets/js/components/song/SongContextMenu.spec.ts` (+1 -1) 📝 `resources/assets/js/stores/preferenceStore.ts` (+1 -1) 📝 `tests/Integration/Services/FileSynchronizerTest.php` (+25 -1) 📝 `tests/Unit/Models/SongTest.php` (+8 -0) ➕ `tests/Unit/Services/SimpleLrcReaderTest.php` (+30 -0) ➕ `tests/blobs/simple.lrc` (+3 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:06 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1733

No description provided.

Rows
Columns