[PR #1458] [MERGED] feat: Add env TRANSCODE_FLAC (default true) to toggle transcoding on/off for FLAC files #1722

New issue

Closed

opened 2026-02-26 03:32:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1458
Author: @MaciejGorczyca
Created: 6/11/2022
Status: ✅ Merged
Merged: 10/8/2022
Merged by: @phanan

Base: master ← Head: master

📝 Commits (1)

4a10a78 Add env TRANSCODE_FLAC (default true) that allows toggling off transcoding when file type is FLAC

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 app/Services/TranscodingService.php (+1 -1)
📝 config/koel.php (+1 -0)

📄 Description

It seems there were some attempts at making this work before but apparently they weren't done the right way or something.

The following request was closed as stale: https://github.com/koel/koel/pull/527

The following request was denied due to confusing label and wrong approach (?) https://github.com/koel/koel/pull/699

The only changes are: new config variable koel.streaming.transcode_flac that pulls data from TRANSCODE_FLAC env var and defaults to true in config/koel.php file and extended bool check in app/Services/TranscodingService.php file. Full diff here.

The default behavior is the same as before but now you can turn off transcoding simply by setting env variable.

I built the Docker image with my changes here: https://hub.docker.com/r/coust/koel

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1458 **Author:** [@MaciejGorczyca](https://github.com/MaciejGorczyca) **Created:** 6/11/2022 **Status:** ✅ Merged **Merged:** 10/8/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`4a10a78`](https://github.com/koel/koel/commit/4a10a787768e27fa23926cabe7f40077ff595875) Add env TRANSCODE_FLAC (default true) that allows toggling off transcoding when file type is FLAC ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/TranscodingService.php` (+1 -1) 📝 `config/koel.php` (+1 -0) </details> ### 📄 Description It seems there were some attempts at making this work before but apparently they weren't done the right way or something. The following request was closed as stale: https://github.com/koel/koel/pull/527 The following request was denied due to confusing label and wrong approach (?) https://github.com/koel/koel/pull/699 --- The only changes are: new config variable `koel.streaming.transcode_flac` that pulls data from `TRANSCODE_FLAC` env var and defaults to `true` in `config/koel.php` file and extended bool check in `app/Services/TranscodingService.php` file. [Full diff here.](https://github.com/koel/koel/compare/master...MaciejGorczyca:master#diff-c394adf35324659049bb91f7b82378371d236078ffeb27da855a076867d13f5e) The default behavior is the same as before but now you can turn off transcoding simply by setting env variable. I built the Docker image with my changes here: https://hub.docker.com/r/coust/koel --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:04 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1722

No description provided.

Rows
Columns