[PR #1426] [MERGED] Fix S3 storage song compilation setting #1710

New issue

Closed

opened 2026-02-26 03:32:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1426
Author: @ktravis
Created: 2/19/2022
Status: ✅ Merged
Merged: 4/13/2022
Merged by: @phanan

Base: master ← Head: s3-album-artist-fix

📝 Commits (2)

12ff5c9 fix s3 song compilation setting
2c22827 Use !== in albumartist comparison

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 app/Http/Controllers/API/ObjectStorage/S3/SongController.php (+4 -2)

📄 Description

The S3 song controller was setting compilation to true as long as an album artist was specified, even if it matched the artist tag. This PR adjusts the behavior to match the isCompilation method defined here: github.com/koel/koel@aedff9cf6e/app/Services/FileSynchronizer.php (L338-L345)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1426 **Author:** [@ktravis](https://github.com/ktravis) **Created:** 2/19/2022 **Status:** ✅ Merged **Merged:** 4/13/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `s3-album-artist-fix` --- ### 📝 Commits (2) - [`12ff5c9`](https://github.com/koel/koel/commit/12ff5c90bbe8f98bdfb7efa7ec4073eeeb00f535) fix s3 song compilation setting - [`2c22827`](https://github.com/koel/koel/commit/2c228272a6d640570fcc83f1f837536a3a5afe96) Use !== in albumartist comparison ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/API/ObjectStorage/S3/SongController.php` (+4 -2) </details> ### 📄 Description The S3 song controller was setting `compilation` to true as long as an album artist was specified, even if it matched the artist tag. This PR adjusts the behavior to match the `isCompilation` method defined here: https://github.com/koel/koel/blob/aedff9cf6e055fa7f58eb08e52206ea750f33be2/app/Services/FileSynchronizer.php#L338-L345 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:01 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1710

No description provided.

Rows
Columns