[PR #1390] [MERGED] fix: do not remove S3-hosted songs post-sync #1700

New issue

Closed

opened 2026-02-26 03:31:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:31:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1390
Author: @phanan
Created: 12/6/2021
Status: ✅ Merged
Merged: 12/6/2021
Merged by: @phanan

Base: master ← Head: s3-fix

📝 Commits (1)

2e872c9 fix: do not remove S3-hosted songs post-sync

📊 Changes

28 files changed (+372 additions, -157 deletions)

View changed files

➕ app/Events/MediaSyncCompleted.php (+18 -0)
📝 app/Events/SongsBatchUnliked.php (+1 -1)
➕ app/Exceptions/SongPathNotFoundException.php (+19 -0)
📝 app/Http/Controllers/API/ObjectStorage/S3/SongController.php (+24 -53)
➕ app/Listeners/DeleteNonExistingRecordsPostSync.php (+31 -0)
📝 app/Models/Album.php (+0 -1)
📝 app/Models/Artist.php (+0 -1)
📝 app/Models/Interaction.php (+0 -2)
📝 app/Models/Playlist.php (+0 -2)
📝 app/Models/Song.php (+1 -18)
📝 app/Models/SupportsDeleteWhereIDsNotIn.php (+3 -11)
➕ app/Models/SupportsS3.php (+39 -0)
📝 app/Observers/SongObserver.php (+5 -5)
📝 app/Providers/EventServiceProvider.php (+6 -0)
📝 app/Repositories/SongRepository.php (+12 -5)
📝 app/Services/FileSynchronizer.php (+4 -4)
📝 app/Services/Helper.php (+1 -1)
📝 app/Services/MediaSyncService.php (+8 -19)
📝 app/Services/S3Service.php (+72 -2)
➖ app/Traits/CanFilterByUser.php (+0 -16)

...and 8 more files

📄 Description

Closes #1379.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1390 **Author:** [@phanan](https://github.com/phanan) **Created:** 12/6/2021 **Status:** ✅ Merged **Merged:** 12/6/2021 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `s3-fix` --- ### 📝 Commits (1) - [`2e872c9`](https://github.com/koel/koel/commit/2e872c982a76f03e88285beef889f4bda24a2ca4) fix: do not remove S3-hosted songs post-sync ### 📊 Changes **28 files changed** (+372 additions, -157 deletions) <details> <summary>View changed files</summary> ➕ `app/Events/MediaSyncCompleted.php` (+18 -0) 📝 `app/Events/SongsBatchUnliked.php` (+1 -1) ➕ `app/Exceptions/SongPathNotFoundException.php` (+19 -0) 📝 `app/Http/Controllers/API/ObjectStorage/S3/SongController.php` (+24 -53) ➕ `app/Listeners/DeleteNonExistingRecordsPostSync.php` (+31 -0) 📝 `app/Models/Album.php` (+0 -1) 📝 `app/Models/Artist.php` (+0 -1) 📝 `app/Models/Interaction.php` (+0 -2) 📝 `app/Models/Playlist.php` (+0 -2) 📝 `app/Models/Song.php` (+1 -18) 📝 `app/Models/SupportsDeleteWhereIDsNotIn.php` (+3 -11) ➕ `app/Models/SupportsS3.php` (+39 -0) 📝 `app/Observers/SongObserver.php` (+5 -5) 📝 `app/Providers/EventServiceProvider.php` (+6 -0) 📝 `app/Repositories/SongRepository.php` (+12 -5) 📝 `app/Services/FileSynchronizer.php` (+4 -4) 📝 `app/Services/Helper.php` (+1 -1) 📝 `app/Services/MediaSyncService.php` (+8 -19) 📝 `app/Services/S3Service.php` (+72 -2) ➖ `app/Traits/CanFilterByUser.php` (+0 -16) _...and 8 more files_ </details> ### 📄 Description Closes #1379. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:31:59 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:32 +03:00

[PR #1700] [CLOSED] chore(deps): bump word-wrap from 1.2.3 to 1.2.4 #1849

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1700

No description provided.

Rows
Columns