[PR #1326] [MERGED] feat: require PHP7.4 #1682

Closed
opened 2026-02-26 03:31:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1326
Author: @phanan
Created: 6/4/2021
Status: Merged
Merged: 6/5/2021
Merged by: @phanan

Base: masterHead: php74


📝 Commits (1)

📊 Changes

123 files changed (+973 additions, -1133 deletions)

View changed files

📝 .github/workflows/unit.yml (+1 -1)
📝 app/Console/Commands/Admin/ChangePasswordCommand.php (+2 -2)
📝 app/Console/Commands/InitCommand.php (+7 -7)
📝 app/Console/Commands/SyncCommand.php (+9 -21)
📝 app/Console/Commands/TidyLibraryCommand.php (+1 -1)
📝 app/Events/AlbumInformationFetched.php (+3 -5)
📝 app/Events/ArtistInformationFetched.php (+3 -5)
📝 app/Events/SongLikeToggled.php (+2 -2)
📝 app/Events/SongStartedPlaying.php (+2 -2)
📝 app/Events/SongsBatchLiked.php (+2 -2)
📝 app/Events/SongsBatchUnliked.php (+2 -2)
📝 app/Factories/SmartPlaylistRuleParameterFactory.php (+8 -24)
📝 app/Factories/StreamerFactory.php (+4 -4)
📝 app/Helpers.php (+2 -10)
📝 app/Http/Controllers/API/AlbumCoverController.php (+1 -1)
📝 app/Http/Controllers/API/AlbumThumbnailController.php (+1 -1)
📝 app/Http/Controllers/API/ArtistImageController.php (+1 -1)
📝 app/Http/Controllers/API/AuthController.php (+5 -5)
📝 app/Http/Controllers/API/DataController.php (+10 -10)
📝 app/Http/Controllers/API/Interaction/Controller.php (+2 -2)

...and 80 more files

📄 Description

PHP 7.4 has been released a year and a half ago. Time to upgrade.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1326 **Author:** [@phanan](https://github.com/phanan) **Created:** 6/4/2021 **Status:** ✅ Merged **Merged:** 6/5/2021 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `php74` --- ### 📝 Commits (1) - [`cb12f16`](https://github.com/koel/koel/commit/cb12f163b1b53eaabf1a4e7644e3b80f3e914459) feat: require PHP7.4 ### 📊 Changes **123 files changed** (+973 additions, -1133 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/unit.yml` (+1 -1) 📝 `app/Console/Commands/Admin/ChangePasswordCommand.php` (+2 -2) 📝 `app/Console/Commands/InitCommand.php` (+7 -7) 📝 `app/Console/Commands/SyncCommand.php` (+9 -21) 📝 `app/Console/Commands/TidyLibraryCommand.php` (+1 -1) 📝 `app/Events/AlbumInformationFetched.php` (+3 -5) 📝 `app/Events/ArtistInformationFetched.php` (+3 -5) 📝 `app/Events/SongLikeToggled.php` (+2 -2) 📝 `app/Events/SongStartedPlaying.php` (+2 -2) 📝 `app/Events/SongsBatchLiked.php` (+2 -2) 📝 `app/Events/SongsBatchUnliked.php` (+2 -2) 📝 `app/Factories/SmartPlaylistRuleParameterFactory.php` (+8 -24) 📝 `app/Factories/StreamerFactory.php` (+4 -4) 📝 `app/Helpers.php` (+2 -10) 📝 `app/Http/Controllers/API/AlbumCoverController.php` (+1 -1) 📝 `app/Http/Controllers/API/AlbumThumbnailController.php` (+1 -1) 📝 `app/Http/Controllers/API/ArtistImageController.php` (+1 -1) 📝 `app/Http/Controllers/API/AuthController.php` (+5 -5) 📝 `app/Http/Controllers/API/DataController.php` (+10 -10) 📝 `app/Http/Controllers/API/Interaction/Controller.php` (+2 -2) _...and 80 more files_ </details> ### 📄 Description PHP 7.4 has been released a year and a half ago. Time to upgrade. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:31:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1682
No description provided.