mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[PR #1326] [MERGED] feat: require PHP7.4 #1682
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1682
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1326
Author: @phanan
Created: 6/4/2021
Status: ✅ Merged
Merged: 6/5/2021
Merged by: @phanan
Base:
master← Head:php74📝 Commits (1)
cb12f16feat: require PHP7.4📊 Changes
123 files changed (+973 additions, -1133 deletions)
View changed files
📝
.github/workflows/unit.yml(+1 -1)📝
app/Console/Commands/Admin/ChangePasswordCommand.php(+2 -2)📝
app/Console/Commands/InitCommand.php(+7 -7)📝
app/Console/Commands/SyncCommand.php(+9 -21)📝
app/Console/Commands/TidyLibraryCommand.php(+1 -1)📝
app/Events/AlbumInformationFetched.php(+3 -5)📝
app/Events/ArtistInformationFetched.php(+3 -5)📝
app/Events/SongLikeToggled.php(+2 -2)📝
app/Events/SongStartedPlaying.php(+2 -2)📝
app/Events/SongsBatchLiked.php(+2 -2)📝
app/Events/SongsBatchUnliked.php(+2 -2)📝
app/Factories/SmartPlaylistRuleParameterFactory.php(+8 -24)📝
app/Factories/StreamerFactory.php(+4 -4)📝
app/Helpers.php(+2 -10)📝
app/Http/Controllers/API/AlbumCoverController.php(+1 -1)📝
app/Http/Controllers/API/AlbumThumbnailController.php(+1 -1)📝
app/Http/Controllers/API/ArtistImageController.php(+1 -1)📝
app/Http/Controllers/API/AuthController.php(+5 -5)📝
app/Http/Controllers/API/DataController.php(+10 -10)📝
app/Http/Controllers/API/Interaction/Controller.php(+2 -2)...and 80 more files
📄 Description
PHP 7.4 has been released a year and a half ago. Time to upgrade.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.