[PR #1209] [MERGED] Fix hotloading #1644

New issue

Closed

opened 2026-02-26 03:31:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:31:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1209
Author: @Hyzual
Created: 4/13/2020
Status: ✅ Merged
Merged: 4/18/2020
Merged by: @phanan

Base: master ← Head: webpack_build

📝 Commits (4)

44729c4 Upgrade webpack to latest
ac8fbca Change port to 8000
44ea6e8 Revert "Upgrade webpack to latest"
a044a00 sync with core

📊 Changes

3 files changed (+8 additions, -2 deletions)

View changed files

📝 app/Application.php (+1 -1)
📝 resources/assets (+1 -1)
📝 webpack.mix.js (+6 -0)

📄 Description

webpack's (major) changelog: https://github.com/webpack/webpack/releases/tag/v4.0.0
laravel-mix's (major) changelog: https://github.com/JeffreyWay/laravel-mix/releases/tag/v5.0.0

How to test:

checkout https://github.com/koel/core/pull/32 to align the assets to the upgrade
yarn run production should succeed and build the assets

How to use hot reload:

$ php artisan serve --port 8000
$ yarn run hot
Browse to http://localhost:8080
Assets should be hot-reloaded. API calls should be proxied to your PHP
server at http://localhost:8000

Note to reviewer:
EDIT: 8000 is now the port
~~- I chose 8088 as port number because that's what is expected by cypress tests. If another port is preferred, let me know.~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1209 **Author:** [@Hyzual](https://github.com/Hyzual) **Created:** 4/13/2020 **Status:** ✅ Merged **Merged:** 4/18/2020 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `webpack_build` --- ### 📝 Commits (4) - [`44729c4`](https://github.com/koel/koel/commit/44729c442eda39c9cc8974d62558835654173e2d) Upgrade webpack to latest - [`ac8fbca`](https://github.com/koel/koel/commit/ac8fbca02302f1ed9cce7ce80c8d60db23a9fb5c) Change port to 8000 - [`44ea6e8`](https://github.com/koel/koel/commit/44ea6e8164a4dd5dce2fed2220dd109926dfd383) Revert "Upgrade webpack to latest" - [`a044a00`](https://github.com/koel/koel/commit/a044a003a620178f6d4bb84b9bde608b3a20525f) sync with core ### 📊 Changes **3 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Application.php` (+1 -1) 📝 `resources/assets` (+1 -1) 📝 `webpack.mix.js` (+6 -0) </details> ### 📄 Description webpack's (major) changelog: https://github.com/webpack/webpack/releases/tag/v4.0.0 laravel-mix's (major) changelog: https://github.com/JeffreyWay/laravel-mix/releases/tag/v5.0.0 How to test: - checkout https://github.com/koel/core/pull/32 to align the assets to the upgrade - yarn run production should succeed and build the assets How to use hot reload: - $ php artisan serve --port 8000 - $ yarn run hot - Browse to http://localhost:8080 - Assets should be hot-reloaded. API calls should be proxied to your PHP server at http://localhost:8000 Note to reviewer: EDIT: 8000 is now the port ~~- I chose 8088 as port number because that's what is expected by cypress tests. If another port is preferred, let me know.~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:31:46 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1644

No description provided.

Rows
Columns