[PR #1189] [MERGED] Fix TranscodingStreamer for PHP 7.4 #1631

New issue

Closed

opened 2026-02-26 03:31:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:31:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1189
Author: @tobbez
Created: 3/4/2020
Status: ✅ Merged
Merged: 3/10/2020
Merged by: @phanan

Base: master ← Head: transcoding-streamer-php7.4

📝 Commits (1)

e7ea465 Fix TranscodingStreamer for PHP 7.4

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 app/Services/Streamers/TranscodingStreamer.php (+1 -1)

📄 Description

Passing the glue parameter after the pieces parameter when calling
implode is deprecated as of PHP 7.4.

This was the only remaining instance, all other implode calls already
use the correct parameter order.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1189 **Author:** [@tobbez](https://github.com/tobbez) **Created:** 3/4/2020 **Status:** ✅ Merged **Merged:** 3/10/2020 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `transcoding-streamer-php7.4` --- ### 📝 Commits (1) - [`e7ea465`](https://github.com/koel/koel/commit/e7ea4651b5c6e6edc30cd1e1da5ab2cdfa8dd0c1) Fix TranscodingStreamer for PHP 7.4 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/Streamers/TranscodingStreamer.php` (+1 -1) </details> ### 📄 Description Passing the glue parameter after the pieces parameter when calling implode is deprecated as of PHP 7.4. This was the only remaining instance, all other implode calls already use the correct parameter order. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:31:44 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:27 +03:00

[PR #1631] [MERGED] feat: allow sorting by date added #1825

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1631

No description provided.

Rows
Columns