starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-25 16:56:02 +03:00

[GH-ISSUE #212] Why is index.php not in public/ ? #153

New issue

Closed

opened 2026-02-26 02:32:18 +03:00 by kerem · 2 comments

kerem commented

2026-02-26 02:32:18 +03:00

Owner

Originally created by @carcinocron on GitHub (Feb 1, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/212

I noticed in the nginx config:

server {
  listen        *:80;
  server_name   koel.dev;
  root          /home/forge/koel.dev;
  index         index.php;

I'm pretty sure the standard in laravel is to use root /home/forge/koel.dev/public; which would also make this rule unnecessary:

  # Deny access to framework directories
  location ~ /(app/|bootstrap/|config/|database/|resources/|storage/tests|vendor/) {
    deny  all;
  }

Is there something I'm missing here? Why was it necessary to not use laravel's default method?

Originally created by @carcinocron on GitHub (Feb 1, 2016). Original GitHub issue: https://github.com/koel/koel/issues/212 I noticed in the nginx config: ``` server { listen *:80; server_name koel.dev; root /home/forge/koel.dev; index index.php; ``` I'm pretty sure the standard in laravel is to use `root /home/forge/koel.dev/public;` which would also make this rule unnecessary: ``` # Deny access to framework directories location ~ /(app/|bootstrap/|config/|database/|resources/|storage/tests|vendor/) { deny all; } ``` Is there something I'm missing here? Why was it necessary to not use laravel's default method?

kerem closed this issue

2026-02-26 02:32:18 +03:00

kerem commented

2026-02-26 02:32:18 +03:00

Author

Owner

@phanan commented on GitHub (Feb 1, 2016):

This has been discussed before. Basically I wanted to support those on shared hostings as well. I guess some rewrites would do it as well, but this is more familiar to me.

@phanan commented on GitHub (Feb 1, 2016): This has been discussed before. Basically I wanted to support those on shared hostings as well. I guess some rewrites would do it as well, but this is more familiar to me.

kerem commented

2026-02-26 02:32:18 +03:00

Author

Owner

@kikoseijo commented on GitHub (Nov 21, 2017):

Hi there,
Nice job here, its good, really, amazing.

You should put in the installation that its not like laravel, because it builds directly from root folder, took me while to realise- after coulee reads on instructions.

I have this automatised installation on Laravel, but this part its different.

Happy days!

@kikoseijo commented on GitHub (Nov 21, 2017): Hi there, Nice job here, its good, really, amazing. You should put in the installation that its not like laravel, because it builds directly from root folder, took me while to realise- after coulee reads on instructions. I have this automatised installation on Laravel, but this part its different. Happy days!

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#153

No description provided.

Rows
Columns