[PR #1003] [CLOSED] Fixes missing cover when toggling compilation state of a song. #1513

Closed
opened 2026-02-26 03:31:18 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1003
Author: @patric-eberle
Created: 6/22/2019
Status: Closed

Base: masterHead: bugfix/compilation-cover


📝 Commits (2)

  • ff0bfe1 Fixes missing cover when toggling compilation state of a song.
  • 8acc451 Merge branch 'master' into bugfix/compilation-cover

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

📝 app/Models/Song.php (+13 -0)

📄 Description

This PR fixes the loss of of album covers, when changing the compilation flag for songs. Haven't worked with PHP for quite some time, so please excuse if it is not perfect ;)

I decided to just take over the cover from the previously linked album, if it does not exist on the retrieved one and it hat the state wasRecentlyCreated.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1003 **Author:** [@patric-eberle](https://github.com/patric-eberle) **Created:** 6/22/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bugfix/compilation-cover` --- ### 📝 Commits (2) - [`ff0bfe1`](https://github.com/koel/koel/commit/ff0bfe1c60e2745f26fc8cc172412f3c8b831fbb) Fixes missing cover when toggling compilation state of a song. - [`8acc451`](https://github.com/koel/koel/commit/8acc4513e1ebf2307587301b510e42ff52b9d26d) Merge branch 'master' into bugfix/compilation-cover ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/Models/Song.php` (+13 -0) </details> ### 📄 Description This PR fixes the loss of of album covers, when changing the compilation flag for songs. Haven't worked with PHP for quite some time, so please excuse if it is not perfect ;) I decided to just take over the cover from the previously linked album, if it does not exist on the retrieved one and it hat the state `wasRecentlyCreated`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:31:18 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1513
No description provided.