mirror of
https://github.com/koel/koel.git
synced 2026-04-26 09:15:59 +03:00
[PR #1003] [CLOSED] Fixes missing cover when toggling compilation state of a song. #1513
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1513
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1003
Author: @patric-eberle
Created: 6/22/2019
Status: ❌ Closed
Base:
master← Head:bugfix/compilation-cover📝 Commits (2)
ff0bfe1Fixes missing cover when toggling compilation state of a song.8acc451Merge branch 'master' into bugfix/compilation-cover📊 Changes
1 file changed (+13 additions, -0 deletions)
View changed files
📝
app/Models/Song.php(+13 -0)📄 Description
This PR fixes the loss of of album covers, when changing the compilation flag for songs. Haven't worked with PHP for quite some time, so please excuse if it is not perfect ;)
I decided to just take over the cover from the previously linked album, if it does not exist on the retrieved one and it hat the state
wasRecentlyCreated.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.