mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[PR #975] [MERGED] Make it easier to contribute to koel by having an online IDE #1486
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1486
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/975
Author: @meysholdt
Created: 5/17/2019
Status: ✅ Merged
Merged: 5/21/2019
Merged by: @phanan
Base:
master← Head:master📝 Commits (2)
7e251c2Added Gitpod Config6942f70Start with music in the playlist📊 Changes
3 files changed (+45 additions, -0 deletions)
View changed files
➕
.gitpod.dockerfile(+3 -0)➕
.gitpod.yml(+38 -0)📝
README.md(+4 -0)📄 Description
Hi There! hi @phanan!
I wanted to try koel but setting up may dev environment took painfully long. All that tinkering...
So I thought we can make that easier for everybody by having an online IDE (gitpod.io)) where everything is already configured, so that one can start running and hacking koel with just one click.
If you click on the following link....
https://gitpod.io/#https://github.com/meysholdt/koel
Dockerfilein this PRgit clonewill fetch the koel source code. You may need to GitHub-OAuth-Login here..env.examplescript is copied to.env.envis created.php artisan koel:initruns to let the user create a new loginWhat you see then looks like this:
Disclosure: I work on Gitpod.
Let me know what you think. I hope you find this useful. I personally think this can make it significantly easier to contribute to koel.
There is, however, one problem I ran into. koel seems to have trouble with being behind a https-proxy. This was already reported in #725. This issue bites us when using Gitpod, because you open koel in your browser, your requests go trough a https-proxy (operated by Gitpod) to the koel-instance from your workspace. Unfortunately, koel often sends
httprequests, even though it's served viahttps. I'm happy to help out a little, but I'm not enough familiar with koel to do this on my own.I noticed that
composer installandyarn installtake several minutes to run. If you configure the Gitpod App on this repo, Gitpod can run them on git-push on branches and PRs. So when you open a workspace,composer installandyarn installwill already have finished and you don't need to wait for them.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.