mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[PR #886] [MERGED] Non interactive koel:init #1417
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1417
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/886
Author: @javier-lopez
Created: 12/31/2018
Status: ✅ Merged
Merged: 1/1/2019
Merged by: @phanan
Base:
master← Head:non-interactive-koel-init📝 Commits (6)
6866663Use ADMIN_* variables if available to create the admin account5ee2009Add APP_MEDIA_PATH for media directory3ea4bc7Use the standard --no-interaction flag to koel:init5b9c034Undo variable aligment and code formattingcca03c5Prefer early return over else, add new line before return statements397b8ffSome fixes📊 Changes
8 files changed (+98 additions, -36 deletions)
View changed files
📝
.env.example(+13 -0)📝
app/Console/Commands/InitCommand.php(+66 -18)📝
app/Repositories/AbstractRepository.php(+10 -2)📝
app/Repositories/SongRepository.php(+2 -2)📝
app/Services/MediaMetadataService.php(+2 -2)📝
app/Services/MediaSyncService.php(+2 -2)📝
config/koel.php(+2 -0)📝
tests/Integration/Repositories/SongRepositoryTest.php(+1 -10)📄 Description
As per
github.com/phanan/koel@e1b68cc53f (diff-ac5db72ed5)(Dec 3, 2017), the admin account is NOT set in the.envfile and created during initial database seeding anymore, therefore it's required to run:In interactive mode to configure koel, such process can be automatized with expect but IMHO it could be better if it uses environment variables when available.
This PR re enable:
And add:
To be able to run
$ php artisan koel:initin non interactive mode🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.