mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #197] last.fm scrobbling persistence #140
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#140
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @orlin on GitHub (Jan 21, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/197
Last.fm scrobbling seems to be sessions-based, kept solely on the client app. I first noticed this by authorizing with last.fm using one app and immediately having to do it again with another device / app. Also, every time I restart the server I have to re-authorize once again. It doesn't feel like a user setting. I would much rather be asked up-front before each session. Sometimes I forget and there is a good random song playing, and then another, and I keep postponing to reactivate it because I rather not stop the music (and wipe my random list). It would be best if the last.fm authorization was kept ongoing by the server and only had to be done once. I'm guessing this will happen anyway since
.envhas fast.fm config in it...@phanan commented on GitHub (Jan 22, 2016):
Last.fm connection is persistent actually, and I've been using it since day one without such problems. If possible, please explore more and file a bug report with the details. Thanks.
@orlin commented on GitHub (Jan 24, 2016):
Sorry, my mistake. However, here is what led me to believe this... Installed and configured the server, opened it on my desktop and started playing, meanwhile I also opened it on my iPad to see what it looks like - having noticed it doesn't scrobble, I found the part where I need to authorize with last.fm - this picked up on the current client but the other wasn't scrobbling so I authorized again and then both scrobbled fine. Something probably loads with the client app that tells it there is no connection? Since the server probably doesn't push the change, the app didn't know.
Later on, I only noticed the "reconnect" button (and not the "disconnect") - not sure what it says to begin with, I just assumed that if it gives me "reconnect" there must be something wrong with the connection, my bad.
@phanan commented on GitHub (Jan 25, 2016):
You're right, if you open Koel on two devices at the same time and connect
to Last.fm on one, the other will not be able to detect, because there's no
push mechanism. Scrobbling is currently triggered from client-side, based
on a "useLastfm" variable that is populated upon app start. I'll think
about this limitation.
On Mon, Jan 25, 2016 at 2:38 AM, Orlin M Bozhinov notifications@github.com
wrote: