[PR #825] [MERGED] Fix broken tests due to Laravel change #1375

New issue

Closed

opened 2026-02-26 03:30:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:30:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/825
Author: @phanan
Created: 10/6/2018
Status: ✅ Merged
Merged: 10/6/2018
Merged by: @phanan

Base: master ← Head: fix-tests

📝 Commits (2)

e4da901 Fix broken tests due to Laravel change
9a42d98 Apply fixes from StyleCI (#824)

📊 Changes

4 files changed (+28 additions, -11 deletions)

View changed files

📝 composer.json (+1 -1)
📝 database/migrations/2016_04_16_082627_create_various_artists.php (+5 -2)
📝 database/migrations/2016_06_16_134516_cascade_delete_user.php (+11 -4)
📝 database/migrations/2017_04_29_025836_rename_contributing_artist_id.php (+11 -4)

📄 Description

A recent change in Laravel 5.7 totally breaks the tests. This fixes the issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/825 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/6/2018 **Status:** ✅ Merged **Merged:** 10/6/2018 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fix-tests` --- ### 📝 Commits (2) - [`e4da901`](https://github.com/koel/koel/commit/e4da901ce582a3b7f9372dbea52ad1897e54914e) Fix broken tests due to Laravel change - [`9a42d98`](https://github.com/koel/koel/commit/9a42d98918590920da17b76c8842e26fc94ae017) Apply fixes from StyleCI (#824) ### 📊 Changes **4 files changed** (+28 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+1 -1) 📝 `database/migrations/2016_04_16_082627_create_various_artists.php` (+5 -2) 📝 `database/migrations/2016_06_16_134516_cascade_delete_user.php` (+11 -4) 📝 `database/migrations/2017_04_29_025836_rename_contributing_artist_id.php` (+11 -4) </details> ### 📄 Description A recent change in Laravel 5.7 [totally breaks the tests](https://github.com/laravel/framework/issues/25475). This fixes the issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:30:47 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:31:58 +03:00

[PR #1375] [CLOSED] Helper documentation #1698

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1375

No description provided.

Rows
Columns