[PR #687] [MERGED] implement simple multi disc support #1322

New issue

Closed

opened 2026-02-26 03:30:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:30:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/687
Author: @fieteboerner
Created: 11/29/2017
Status: ✅ Merged
Merged: 12/3/2017
Merged by: @phanan

Base: master ← Head: multi-disc

📝 Commits (10+)

20ab22b add disc field to songs table via migration
f4319b5 add disc field to song model
aa16443 collect disc information in file sync process
4360814 sort song list by disc and track number in album context
a6369d1 check the disc field in file test
ff895ba remove nullable flag from disc field in add_disc_into_songs migration
8948b4a fix php code style issues
29ebd7d fix js code style
2897f4a fix sort usage in song-list
15f1edc sort songs by inserting into queue by clicking the album/artist item play button (album_id, disc, track)

📊 Changes

10 files changed (+53 additions, -5 deletions)

View changed files

📝 app/Models/File.php (+1 -0)
📝 app/Models/Song.php (+2 -0)
📝 app/Services/Media.php (+1 -0)
➕ database/migrations/2017_11_27_184010_add_disc_into_songs.php (+32 -0)
📝 resources/assets/js/components/shared/album-item.vue (+2 -1)
📝 resources/assets/js/components/shared/artist-item.vue (+2 -1)
📝 resources/assets/js/components/shared/song-list.vue (+10 -1)
📝 resources/assets/js/services/playback.js (+2 -2)
📝 tests/Unit/FileTest.php (+1 -0)
📝 tests/songs/full.mp3 (+0 -0)

📄 Description

extract the disc number from id3 tags by indexing song files.
Sort the song list of an album by the disc number to avoid attaching the disc number to the album name like described in this issue #574

After upgrading the db scheme with php artisan koel:init you have to reindex your music library with php artisan koel:sync --force

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/687 **Author:** [@fieteboerner](https://github.com/fieteboerner) **Created:** 11/29/2017 **Status:** ✅ Merged **Merged:** 12/3/2017 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `multi-disc` --- ### 📝 Commits (10+) - [`20ab22b`](https://github.com/koel/koel/commit/20ab22b18e0d3be8267b48fac66037b034de1920) add disc field to songs table via migration - [`f4319b5`](https://github.com/koel/koel/commit/f4319b535e16e3740d2364a36eb09a606f8abc0e) add disc field to song model - [`aa16443`](https://github.com/koel/koel/commit/aa164436b0e02942ca284ac0da51372fe53912d7) collect disc information in file sync process - [`4360814`](https://github.com/koel/koel/commit/43608146004fd89e63b2fa631660c7a7181aa911) sort song list by disc and track number in album context - [`a6369d1`](https://github.com/koel/koel/commit/a6369d1272ad23a14f9810523419068cda183851) check the disc field in file test - [`ff895ba`](https://github.com/koel/koel/commit/ff895ba695554d50c4c8c3af3229aa1dcb79ae18) remove nullable flag from disc field in add_disc_into_songs migration - [`8948b4a`](https://github.com/koel/koel/commit/8948b4a99972480014d464e1424b2a373774839c) fix php code style issues - [`29ebd7d`](https://github.com/koel/koel/commit/29ebd7d98fe992bc357d0c8d816412621ca68c21) fix js code style - [`2897f4a`](https://github.com/koel/koel/commit/2897f4a432254e1f90c91f88bf6177f0ba07c7ca) fix sort usage in song-list - [`15f1edc`](https://github.com/koel/koel/commit/15f1edcbe7d44d18daf33bf02ecb5f2e3f60bf2e) sort songs by inserting into queue by clicking the album/artist item play button (album_id, disc, track) ### 📊 Changes **10 files changed** (+53 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Models/File.php` (+1 -0) 📝 `app/Models/Song.php` (+2 -0) 📝 `app/Services/Media.php` (+1 -0) ➕ `database/migrations/2017_11_27_184010_add_disc_into_songs.php` (+32 -0) 📝 `resources/assets/js/components/shared/album-item.vue` (+2 -1) 📝 `resources/assets/js/components/shared/artist-item.vue` (+2 -1) 📝 `resources/assets/js/components/shared/song-list.vue` (+10 -1) 📝 `resources/assets/js/services/playback.js` (+2 -2) 📝 `tests/Unit/FileTest.php` (+1 -0) 📝 `tests/songs/full.mp3` (+0 -0) </details> ### 📄 Description extract the disc number from id3 tags by indexing song files. Sort the song list of an album by the disc number to avoid attaching the disc number to the album name like described in this issue #574 After upgrading the db scheme with `php artisan koel:init` you have to reindex your music library with `php artisan koel:sync --force` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:30:35 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1322

No description provided.

Rows
Columns