[PR #673] [MERGED] add support for non root installations #1315

New issue

Closed

opened 2026-02-26 03:30:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:30:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/673
Author: @fieteboerner
Created: 10/25/2017
Status: ✅ Merged
Merged: 10/26/2017
Merged by: @phanan

Base: master ← Head: subdir-improved

📝 Commits (4)

3baef17 remove all absolute forward slashes to make relative urls
6e3b6eb set global baseUrl in common blade template
38d86d0 fix absolute url paths in scss
218f736 rename baseUrl to BASE_URL

📊 Changes

21 files changed (+34 additions, -30 deletions)

View changed files

📝 resources/assets/js/components/auth/login-form.vue (+1 -1)
📝 resources/assets/js/components/main-wrapper/extra/album-info.vue (+1 -1)
📝 resources/assets/js/components/main-wrapper/main-content/album.vue (+1 -1)
📝 resources/assets/js/components/main-wrapper/main-content/profile.vue (+1 -1)
📝 resources/assets/js/components/main-wrapper/sidebar/index.vue (+8 -8)
📝 resources/assets/js/components/main-wrapper/sidebar/playlist-item.vue (+1 -1)
📝 resources/assets/js/components/shared/album-item.vue (+2 -2)
📝 resources/assets/js/components/shared/artist-item.vue (+1 -1)
📝 resources/assets/js/components/shared/home-song-item.vue (+1 -1)
📝 resources/assets/js/components/shared/sound-bar.vue (+1 -1)
📝 resources/assets/js/components/shared/track-list-item.vue (+1 -1)
📝 resources/assets/js/components/site-footer/index.vue (+4 -4)
📝 resources/assets/js/components/site-header/user-badge.vue (+1 -1)
📝 resources/assets/js/router.js (+2 -1)
📝 resources/assets/js/services/download.js (+1 -1)
📝 resources/assets/js/services/http.js (+1 -1)
📝 resources/assets/js/services/socket.js (+1 -1)
📝 resources/assets/js/stores/song.js (+1 -1)
📝 resources/views/client-js-vars.blade.php (+2 -1)
📝 resources/views/index.blade.php (+1 -0)

...and 1 more files

📄 Description

this is an improvement of #671
All absolute paths were replaced with relative ones. The base url is set by Laravel in client-js-vars.blade.php. In API calls the base url is used instead of the root url.
With these changes it is possible to use the koel server also in a sub folder of a web server.

These changes are working fine. I hope this can be used so other people can use this functionality. #529

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/673 **Author:** [@fieteboerner](https://github.com/fieteboerner) **Created:** 10/25/2017 **Status:** ✅ Merged **Merged:** 10/26/2017 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `subdir-improved` --- ### 📝 Commits (4) - [`3baef17`](https://github.com/koel/koel/commit/3baef1750d65dcb5671fb58e45113d590e7b8e8a) remove all absolute forward slashes to make relative urls - [`6e3b6eb`](https://github.com/koel/koel/commit/6e3b6eb8ee61e9d4c8f6f09a10c412561c91d26c) set global baseUrl in common blade template - [`38d86d0`](https://github.com/koel/koel/commit/38d86d0c65443c826e8f7ddeb0805686200ba7d0) fix absolute url paths in scss - [`218f736`](https://github.com/koel/koel/commit/218f736a752d275f1098bfe1547e4be16bfbb322) rename baseUrl to BASE_URL ### 📊 Changes **21 files changed** (+34 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/auth/login-form.vue` (+1 -1) 📝 `resources/assets/js/components/main-wrapper/extra/album-info.vue` (+1 -1) 📝 `resources/assets/js/components/main-wrapper/main-content/album.vue` (+1 -1) 📝 `resources/assets/js/components/main-wrapper/main-content/profile.vue` (+1 -1) 📝 `resources/assets/js/components/main-wrapper/sidebar/index.vue` (+8 -8) 📝 `resources/assets/js/components/main-wrapper/sidebar/playlist-item.vue` (+1 -1) 📝 `resources/assets/js/components/shared/album-item.vue` (+2 -2) 📝 `resources/assets/js/components/shared/artist-item.vue` (+1 -1) 📝 `resources/assets/js/components/shared/home-song-item.vue` (+1 -1) 📝 `resources/assets/js/components/shared/sound-bar.vue` (+1 -1) 📝 `resources/assets/js/components/shared/track-list-item.vue` (+1 -1) 📝 `resources/assets/js/components/site-footer/index.vue` (+4 -4) 📝 `resources/assets/js/components/site-header/user-badge.vue` (+1 -1) 📝 `resources/assets/js/router.js` (+2 -1) 📝 `resources/assets/js/services/download.js` (+1 -1) 📝 `resources/assets/js/services/http.js` (+1 -1) 📝 `resources/assets/js/services/socket.js` (+1 -1) 📝 `resources/assets/js/stores/song.js` (+1 -1) 📝 `resources/views/client-js-vars.blade.php` (+2 -1) 📝 `resources/views/index.blade.php` (+1 -0) _...and 1 more files_ </details> ### 📄 Description this is an improvement of #671 All absolute paths were replaced with relative ones. The base url is set by Laravel in `client-js-vars.blade.php`. In API calls the base url is used instead of the root url. With these changes it is possible to use the koel server also in a sub folder of a web server. These changes are working fine. I hope this can be used so other people can use this functionality. #529 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:30:34 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:31:53 +03:00

[PR #1315] [CLOSED] chore(deps): bump url-parse from 1.4.7 to 1.5.1 #1674

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1315

No description provided.

Rows
Columns