[PR #527] [CLOSED] Do not transcode flac on newer chrome and firefox #1277

New issue

Closed

opened 2026-02-26 03:30:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:30:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/527
Author: @cdsboy
Created: 1/24/2017
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

db83b4e Do not transcode flac on newer chrome and firefox
72eacbe Fix import style

📊 Changes

4 files changed (+125 additions, -2 deletions)

View changed files

📝 app/Http/Controllers/API/SongController.php (+8 -1)
📝 composer.json (+2 -1)
📝 composer.lock (+112 -0)
📝 config/app.php (+3 -0)

📄 Description

Chrome 56 and Firefox 51 added support for native flac in the browser. This PR adds support for intelligently enabling transcoding based on user agent.

I've never written php or used composer before, so let me know if there's anything I can do to make this pull request better!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/527 **Author:** [@cdsboy](https://github.com/cdsboy) **Created:** 1/24/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`db83b4e`](https://github.com/koel/koel/commit/db83b4eac6cbc251538f01710b19b24cf990f4b2) Do not transcode flac on newer chrome and firefox - [`72eacbe`](https://github.com/koel/koel/commit/72eacbe4008db7b012258308a96443caf708571a) Fix import style ### 📊 Changes **4 files changed** (+125 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/API/SongController.php` (+8 -1) 📝 `composer.json` (+2 -1) 📝 `composer.lock` (+112 -0) 📝 `config/app.php` (+3 -0) </details> ### 📄 Description Chrome 56 and Firefox 51 added support for native flac in the browser. This PR adds support for intelligently enabling transcoding based on user agent. I've never written php or used composer before, so let me know if there's anything I can do to make this pull request better! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:30:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1277

No description provided.

Rows
Columns