[PR #423] [CLOSED] Split settings saving from media library synchronization #1248

New issue

Closed

opened 2026-02-26 03:30:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:30:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/423
Author: @X-Ryl669
Created: 8/24/2016
Status: ❌ Closed

Base: master ← Head: splitSyncFromSettings

📝 Commits (1)

19e4247 Split settings saving from media library synchronization

📊 Changes

8 files changed (+121 additions, -11 deletions)

View changed files

📝 app/Http/Controllers/API/SettingController.php (+1 -5)
➕ app/Http/Controllers/API/SyncController.php (+26 -0)
➕ app/Http/Requests/API/SyncRequest.php (+30 -0)
📝 app/Http/routes.php (+1 -0)
📝 app/Models/File.php (+10 -0)
📝 resources/assets/js/components/main-wrapper/main-content/settings.vue (+35 -4)
📝 tests/SettingTest.php (+0 -2)
➕ tests/SyncTest.php (+18 -0)

📄 Description

The former is a change to the DB config (instantaneous), the later an (possibly long) action.
Because of the processing time to sync the complete media library path, and the running time limit imposed by the webserver (which can no be modified without side effects), the sync' failed, and returns an error to the user who thinks the settings could not be saved instead because the UI says "Save settings" (and only if the user waited for the timeout...)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/423 **Author:** [@X-Ryl669](https://github.com/X-Ryl669) **Created:** 8/24/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `splitSyncFromSettings` --- ### 📝 Commits (1) - [`19e4247`](https://github.com/koel/koel/commit/19e4247e9d3735247b7de892aa86066a76dcdbe6) Split settings saving from media library synchronization ### 📊 Changes **8 files changed** (+121 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/API/SettingController.php` (+1 -5) ➕ `app/Http/Controllers/API/SyncController.php` (+26 -0) ➕ `app/Http/Requests/API/SyncRequest.php` (+30 -0) 📝 `app/Http/routes.php` (+1 -0) 📝 `app/Models/File.php` (+10 -0) 📝 `resources/assets/js/components/main-wrapper/main-content/settings.vue` (+35 -4) 📝 `tests/SettingTest.php` (+0 -2) ➕ `tests/SyncTest.php` (+18 -0) </details> ### 📄 Description The former is a change to the DB config (instantaneous), the later an (possibly long) action. Because of the processing time to sync the complete media library path, and the running time limit imposed by the webserver (which can no be modified without side effects), the sync' failed, and returns an error to the user who thinks the settings could not be saved instead because the UI says "Save settings" (and only if the user waited for the timeout...) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:30:17 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:31:49 +03:00

[PR #1248] [CLOSED] chore(deps): bump http-proxy from 1.17.0 to 1.18.1 #1658

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1248

No description provided.

Rows
Columns