[PR #401] [MERGED] Allow music library scanning to follow symbolic links #1235

New issue

Closed

opened 2026-02-26 02:35:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 02:35:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/401
Author: @X-Ryl669
Created: 8/10/2016
Status: ✅ Merged
Merged: 8/11/2016
Merged by: @phanan

Base: master ← Head: fork

📝 Commits (1)

60d25b5 Allow music library scanning to follow symbolic links whenever applicable

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 app/Services/Media.php (+1 -0)

📄 Description

By default, Koel does not follow symbolic links while scanning the music library (see issue #389). This is unfortunate for 2 reasons:

Koel does not allow adding multiple music library path (so it's not possible to have per-user music library), thus all users will see the same music library (and obviously, the most limited one).
It's possible to simulate the feature by adding symbolic links in the music library so it points to the user's folder (any users will see the music from all users), but without this patch, it does not work.

I'm not sure what should be the ideal solution for point 1, because if we have multiple path to to the music library, then it also means setting some kind of permission from cross-users access to the library and their personal library. At least with point 2, it's a "gather the world in peace" solution, even if not perfect.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/401 **Author:** [@X-Ryl669](https://github.com/X-Ryl669) **Created:** 8/10/2016 **Status:** ✅ Merged **Merged:** 8/11/2016 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fork` --- ### 📝 Commits (1) - [`60d25b5`](https://github.com/koel/koel/commit/60d25b5b8e152149303bccdd4473471cd0375d85) Allow music library scanning to follow symbolic links whenever applicable ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/Media.php` (+1 -0) </details> ### 📄 Description By default, Koel does not follow symbolic links while scanning the music library (see issue #389). This is unfortunate for 2 reasons: 1. Koel does not allow adding multiple music library path (so it's not possible to have _per-user_ music library), thus all users will see the same music library (and obviously, the most limited one). 2. It's possible to simulate the feature by adding symbolic links in the music library so it points to the user's folder (any users will see the music from all users), but without this patch, it does not work. I'm not sure what should be the ideal solution for point 1, because if we have multiple path to to the music library, then it also means setting some kind of permission from cross-users access to the library and their personal library. At least with point 2, it's a "gather the world in peace" solution, even if not perfect. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 02:35:55 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1235

No description provided.

Rows
Columns