[PR #391] [CLOSED] Prevent click and drag where not anticipated #1231

New issue

Closed

opened 2026-02-26 02:35:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 02:35:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/391
Author: @BernardGoldberger
Created: 8/3/2016
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

5782d36 Prevent click and drag where not anticipated

📊 Changes

13 files changed (+75 additions, -22 deletions)

View changed files

📝 resources/assets/js/components/main-wrapper/extra/album-info.vue (+3 -1)
📝 resources/assets/js/components/main-wrapper/extra/artist-info.vue (+3 -1)
📝 resources/assets/js/components/main-wrapper/extra/youtube.vue (+1 -1)
📝 resources/assets/js/components/main-wrapper/main-content/album.vue (+11 -3)
📝 resources/assets/js/components/main-wrapper/main-content/artist.vue (+10 -2)
📝 resources/assets/js/components/main-wrapper/main-content/favorites.vue (+2 -1)
📝 resources/assets/js/components/main-wrapper/main-content/playlist.vue (+1 -0)
📝 resources/assets/js/components/main-wrapper/main-content/profile.vue (+4 -1)
📝 resources/assets/js/components/main-wrapper/sidebar/index.vue (+31 -8)
📝 resources/assets/js/components/main-wrapper/sidebar/playlist-item.vue (+1 -0)
📝 resources/assets/js/components/shared/user-item.vue (+1 -1)
📝 resources/assets/js/components/site-footer/index.vue (+6 -2)
📝 resources/assets/js/components/site-header/user-badge.vue (+1 -1)

📄 Description

It would happen on occasion that I would mistakenly click and drag items, and if if drag it over a droppable item things would break.

To reproduce this, click and drag the home item on to current queue. The solution is to return false on mouse click down.

I tested it on Windows & iPhone6S the Opera browser and everything if functioning fine after the changes, including clicking and dragging items into the queue.

Besides for th occasional issues it was causing, I believe that it makes the App nicer in general when you don't have weird dragable things in it.

I hope you approve, I tried sticking to your format on things. I'm not a professional programmer which means that there might be a better way to do it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/391 **Author:** [@BernardGoldberger](https://github.com/BernardGoldberger) **Created:** 8/3/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`5782d36`](https://github.com/koel/koel/commit/5782d363846442d2b3c6e21b58aa956e147823c4) Prevent click and drag where not anticipated ### 📊 Changes **13 files changed** (+75 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/main-wrapper/extra/album-info.vue` (+3 -1) 📝 `resources/assets/js/components/main-wrapper/extra/artist-info.vue` (+3 -1) 📝 `resources/assets/js/components/main-wrapper/extra/youtube.vue` (+1 -1) 📝 `resources/assets/js/components/main-wrapper/main-content/album.vue` (+11 -3) 📝 `resources/assets/js/components/main-wrapper/main-content/artist.vue` (+10 -2) 📝 `resources/assets/js/components/main-wrapper/main-content/favorites.vue` (+2 -1) 📝 `resources/assets/js/components/main-wrapper/main-content/playlist.vue` (+1 -0) 📝 `resources/assets/js/components/main-wrapper/main-content/profile.vue` (+4 -1) 📝 `resources/assets/js/components/main-wrapper/sidebar/index.vue` (+31 -8) 📝 `resources/assets/js/components/main-wrapper/sidebar/playlist-item.vue` (+1 -0) 📝 `resources/assets/js/components/shared/user-item.vue` (+1 -1) 📝 `resources/assets/js/components/site-footer/index.vue` (+6 -2) 📝 `resources/assets/js/components/site-header/user-badge.vue` (+1 -1) </details> ### 📄 Description It would happen on occasion that I would mistakenly click and drag items, and if if drag it over a droppable item things would break. To reproduce this, click and drag the home item on to current queue. The solution is to return false on mouse click down. ![image](https://cloud.githubusercontent.com/assets/10334679/17351040/63977082-58f9-11e6-864b-13666c1551da.png) I tested it on Windows & iPhone6S the Opera browser and everything if functioning fine after the changes, including clicking and dragging items into the queue. Besides for th occasional issues it was causing, I believe that it makes the App nicer in general when you don't have weird dragable things in it. I hope you approve, I tried sticking to your format on things. I'm not a professional programmer which means that there might be a better way to do it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 02:35:54 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:31:48 +03:00

[PR #1231] [MERGED] Build via github actions #1650

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1231

No description provided.

Rows
Columns