mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #176] Do not depend on external (font) resources #122
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#122
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TwizzyDizzy on GitHub (Jan 3, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/176
Hi folks,
I think the dependency to external (google font) resources could be removed. As somebody that self-hosts his/her software one may not want to routinely connect to google servers when connecting to one's host.
The following 4 external resources seem to currently be requested:
Cheers
Thomas
@phanan commented on GitHub (Jan 4, 2016):
Actually having fonts self-hosted is in my plan. Gravatar is another case though.
@TwizzyDizzy commented on GitHub (Jan 4, 2016):
Ah, brilliant. As for gravatar: maybe a simple boolean environment var "USE_GRAVATAR" would do.
Cheers
Thomas
@phanan commented on GitHub (Jan 4, 2016):
Nice idea.
On Mon, Jan 4, 2016 at 6:23 PM, Thomas Dalichow notifications@github.com
wrote:
@phanan commented on GitHub (Jan 7, 2016):
Closed in 2.0 branch.