mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[PR #339] [MERGED] feature/filetypes #1216
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1216
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/339
Author: @alex-phillips
Created: 5/22/2016
Status: ✅ Merged
Merged: 6/2/2016
Merged by: @phanan
Base:
master← Head:feature/filetypes📝 Commits (1)
b2ffb28added support for determining to transcode or not via the URL as well as specifying the bitrate, also added support for starting transcode stream at specific point in time of the file📊 Changes
3 files changed (+37 additions, -6 deletions)
View changed files
📝
app/Http/Controllers/API/SongController.php(+14 -3)📝
app/Http/Streamers/TranscodingStreamer.php(+22 -2)📝
app/Http/routes.php(+1 -1)📄 Description
As mentioned yesterday in a different PR, this adds support to better control which file types are transcoded by koel. At the same time, I've gone ahead and added config values to control which file types koel will sync and make available.
These config options are not only future proofing the API for features that could become available in the future, I believe they are also necessary to accommodate other projects that may use koel's backend and API without necessarily using the frontend.
They are only config values, so by default they don't change any behavior or how koel works, but they do allow koel to be used in more ways than those that may be limited by its UI's capabilities.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.