[PR #339] [MERGED] feature/filetypes #1216

Closed
opened 2026-02-26 02:35:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/339
Author: @alex-phillips
Created: 5/22/2016
Status: Merged
Merged: 6/2/2016
Merged by: @phanan

Base: masterHead: feature/filetypes


📝 Commits (1)

  • b2ffb28 added support for determining to transcode or not via the URL as well as specifying the bitrate, also added support for starting transcode stream at specific point in time of the file

📊 Changes

3 files changed (+37 additions, -6 deletions)

View changed files

📝 app/Http/Controllers/API/SongController.php (+14 -3)
📝 app/Http/Streamers/TranscodingStreamer.php (+22 -2)
📝 app/Http/routes.php (+1 -1)

📄 Description

As mentioned yesterday in a different PR, this adds support to better control which file types are transcoded by koel. At the same time, I've gone ahead and added config values to control which file types koel will sync and make available.

These config options are not only future proofing the API for features that could become available in the future, I believe they are also necessary to accommodate other projects that may use koel's backend and API without necessarily using the frontend.

They are only config values, so by default they don't change any behavior or how koel works, but they do allow koel to be used in more ways than those that may be limited by its UI's capabilities.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/339 **Author:** [@alex-phillips](https://github.com/alex-phillips) **Created:** 5/22/2016 **Status:** ✅ Merged **Merged:** 6/2/2016 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feature/filetypes` --- ### 📝 Commits (1) - [`b2ffb28`](https://github.com/koel/koel/commit/b2ffb28fd3c8ede47a9756e2d81d915ea8961031) added support for determining to transcode or not via the URL as well as specifying the bitrate, also added support for starting transcode stream at specific point in time of the file ### 📊 Changes **3 files changed** (+37 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/API/SongController.php` (+14 -3) 📝 `app/Http/Streamers/TranscodingStreamer.php` (+22 -2) 📝 `app/Http/routes.php` (+1 -1) </details> ### 📄 Description As mentioned yesterday in a different PR, this adds support to better control which file types are transcoded by koel. At the same time, I've gone ahead and added config values to control which file types koel will sync and make available. These config options are not only future proofing the API for features that could become available in the future, I believe they are also necessary to accommodate other projects that may use koel's backend and API without necessarily using the frontend. They are only config values, so by default they don't change any behavior or how koel works, but they do allow koel to be used in more ways than those that may be limited by its UI's capabilities. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 02:35:51 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1216
No description provided.