[PR #273] [MERGED] Sort by Track #1196

New issue

Closed

opened 2026-02-26 02:35:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 02:35:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/273
Author: @alex-phillips
Created: 3/20/2016
Status: ✅ Merged
Merged: 3/20/2016
Merged by: @phanan

Base: master ← Head: feature/sort-by-track

📝 Commits (2)

940cd1a added support for song track numbers as well as subsorting song lists
dde5587 fixed tests by referencing new track column in database

📊 Changes

8 files changed (+63 additions, -7 deletions)

View changed files

📝 app/Models/Song.php (+3 -1)
📝 app/Services/Media.php (+8 -0)
📝 database/factories/ModelFactory.php (+1 -0)
📝 database/migrations/2015_11_23_074713_create_songs_table.php (+1 -0)
📝 resources/assets/js/app.vue (+31 -3)
📝 resources/assets/js/components/modals/edit-songs-form.vue (+7 -0)
📝 resources/assets/js/components/shared/song-list.vue (+6 -3)
📝 tests/SongTest.php (+6 -0)

📄 Description

This adds an optional subSortKey argument to the sort function so that we can perform a subsort on the data structure to allow for sorting by tracks when we sort by album.

This address issue https://github.com/phanan/koel/issues/240

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/273 **Author:** [@alex-phillips](https://github.com/alex-phillips) **Created:** 3/20/2016 **Status:** ✅ Merged **Merged:** 3/20/2016 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feature/sort-by-track` --- ### 📝 Commits (2) - [`940cd1a`](https://github.com/koel/koel/commit/940cd1a9144f310fa311400a5441728f15ee4ae8) added support for song track numbers as well as subsorting song lists - [`dde5587`](https://github.com/koel/koel/commit/dde55879a06c3ad2f9587c694d4b3bef25e5bcb0) fixed tests by referencing new track column in database ### 📊 Changes **8 files changed** (+63 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/Models/Song.php` (+3 -1) 📝 `app/Services/Media.php` (+8 -0) 📝 `database/factories/ModelFactory.php` (+1 -0) 📝 `database/migrations/2015_11_23_074713_create_songs_table.php` (+1 -0) 📝 `resources/assets/js/app.vue` (+31 -3) 📝 `resources/assets/js/components/modals/edit-songs-form.vue` (+7 -0) 📝 `resources/assets/js/components/shared/song-list.vue` (+6 -3) 📝 `tests/SongTest.php` (+6 -0) </details> ### 📄 Description This adds an optional `subSortKey` argument to the sort function so that we can perform a subsort on the data structure to allow for sorting by tracks when we sort by album. This address issue https://github.com/phanan/koel/issues/240 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>