[PR #254] [CLOSED] Sort/play albums by track number #1194

New issue

Closed

opened 2026-02-26 02:35:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 02:35:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/254
Author: @jameshclrk
Created: 2/29/2016
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (9)

0a4e767 Add track to songs table
3d9b34b Changed playAll{InAlbum,ByArtist} to respect the shuffle variable
30bfa9e Add track to the Media service
49254f6 Add track number to song-item view
75a9b82 Added track number header to list view
d22e182 Add track number to stub and make sure it's an int
eeb1171 Play album in order of track number
ad2a8ba Sort album page by track number
0f376d6 Add fake data for song track number

📊 Changes

8 files changed (+65 additions, -5 deletions)

View changed files

📝 app/Services/Media.php (+6 -0)
📝 database/factories/ModelFactory.php (+1 -0)
➕ database/migrations/2016_02_28_035052_add_track_to_songs_table.php (+31 -0)
📝 resources/assets/js/components/shared/album-item.vue (+1 -1)
📝 resources/assets/js/components/shared/song-item.vue (+1 -0)
📝 resources/assets/js/components/shared/song-list.vue (+20 -2)
📝 resources/assets/js/services/playback.js (+4 -2)
📝 resources/assets/js/stubs/song.js (+1 -0)

📄 Description

I haven't used any of the frameworks in use here, so I would appreciate comments on what I have done :)
#240

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/254 **Author:** [@jameshclrk](https://github.com/jameshclrk) **Created:** 2/29/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (9) - [`0a4e767`](https://github.com/koel/koel/commit/0a4e76721b74e1015149019ed5758c3e25cbd697) Add track to songs table - [`3d9b34b`](https://github.com/koel/koel/commit/3d9b34b754bc254d26e9e8cf62ae9128b7f2251b) Changed playAll{InAlbum,ByArtist} to respect the shuffle variable - [`30bfa9e`](https://github.com/koel/koel/commit/30bfa9e997a42cadefb715570c601bfb7daf1f12) Add track to the Media service - [`49254f6`](https://github.com/koel/koel/commit/49254f6421dc4809feaa221fa461585bb2e6f15e) Add track number to song-item view - [`75a9b82`](https://github.com/koel/koel/commit/75a9b826e2ba79b3c047745d6fbb9bf2d6d99743) Added track number header to list view - [`d22e182`](https://github.com/koel/koel/commit/d22e182bf9141b87c1d200f05eca679e49621459) Add track number to stub and make sure it's an int - [`eeb1171`](https://github.com/koel/koel/commit/eeb1171501487eb0f742ca6ba00319e157ebd7a7) Play album in order of track number - [`ad2a8ba`](https://github.com/koel/koel/commit/ad2a8bae65b386913d11e857007ec19c23f7e98d) Sort album page by track number - [`0f376d6`](https://github.com/koel/koel/commit/0f376d66a9e7a61282796f45f0c986e324809927) Add fake data for song track number ### 📊 Changes **8 files changed** (+65 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/Media.php` (+6 -0) 📝 `database/factories/ModelFactory.php` (+1 -0) ➕ `database/migrations/2016_02_28_035052_add_track_to_songs_table.php` (+31 -0) 📝 `resources/assets/js/components/shared/album-item.vue` (+1 -1) 📝 `resources/assets/js/components/shared/song-item.vue` (+1 -0) 📝 `resources/assets/js/components/shared/song-list.vue` (+20 -2) 📝 `resources/assets/js/services/playback.js` (+4 -2) 📝 `resources/assets/js/stubs/song.js` (+1 -0) </details> ### 📄 Description I haven't used any of the frameworks in use here, so I would appreciate comments on what I have done :) #240 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 02:35:46 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:31:44 +03:00

[PR #1194] [MERGED] Apply fixes from StyleCI #1633

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1194

No description provided.

Rows
Columns