mirror of
https://github.com/koel/koel.git
synced 2026-04-26 01:06:00 +03:00
[PR #235] [CLOSED] Remove bower. Fetch plyr from npm instead #1187
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1187
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/235
Author: @rundef
Created: 2/16/2016
Status: ❌ Closed
Base:
master← Head:small-improvements📝 Commits (4)
bd358b3APP_URL .env variable + protect direct node_modules accessd7613c3Remove bower. Fetch plyr from npm insteadc316e41Remove bower install from postinstall script, move plyr to devDependencies816589e...📊 Changes
10 files changed (+327 additions, -285 deletions)
View changed files
📝
.env.example(+1 -0)📝
.htaccess(+3 -0)➖
bower.json(+0 -27)📝
config/app.php(+1 -1)📝
gulpfile.js(+1 -1)📝
package.json(+2 -1)📝
resources/assets/js/components/site-footer/index.vue(+4 -3)📝
resources/assets/js/services/playback.js(+6 -2)📝
resources/assets/sass/app.scss(+1 -1)📝
resources/assets/sass/vendor/_plyr.scss(+308 -249)📄 Description
Hey,
I discovered this app recently and I love it. Thought I could help. This should close #227
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.