[PR #235] [CLOSED] Remove bower. Fetch plyr from npm instead #1187

Closed
opened 2026-02-26 02:35:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/235
Author: @rundef
Created: 2/16/2016
Status: Closed

Base: masterHead: small-improvements


📝 Commits (4)

  • bd358b3 APP_URL .env variable + protect direct node_modules access
  • d7613c3 Remove bower. Fetch plyr from npm instead
  • c316e41 Remove bower install from postinstall script, move plyr to devDependencies
  • 816589e ...

📊 Changes

10 files changed (+327 additions, -285 deletions)

View changed files

📝 .env.example (+1 -0)
📝 .htaccess (+3 -0)
bower.json (+0 -27)
📝 config/app.php (+1 -1)
📝 gulpfile.js (+1 -1)
📝 package.json (+2 -1)
📝 resources/assets/js/components/site-footer/index.vue (+4 -3)
📝 resources/assets/js/services/playback.js (+6 -2)
📝 resources/assets/sass/app.scss (+1 -1)
📝 resources/assets/sass/vendor/_plyr.scss (+308 -249)

📄 Description

Hey,

I discovered this app recently and I love it. Thought I could help. This should close #227


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/235 **Author:** [@rundef](https://github.com/rundef) **Created:** 2/16/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `small-improvements` --- ### 📝 Commits (4) - [`bd358b3`](https://github.com/koel/koel/commit/bd358b30a0a1b645bf959137eb1e9ff859b06837) APP_URL .env variable + protect direct node_modules access - [`d7613c3`](https://github.com/koel/koel/commit/d7613c333076b48b9b680abf5ff085dea28d6575) Remove bower. Fetch plyr from npm instead - [`c316e41`](https://github.com/koel/koel/commit/c316e410cb9830d14c6d6551b3214287b091b5a5) Remove bower install from postinstall script, move plyr to devDependencies - [`816589e`](https://github.com/koel/koel/commit/816589ea6a6ae4cd4641634c901a458e9ac8c775) ... ### 📊 Changes **10 files changed** (+327 additions, -285 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+1 -0) 📝 `.htaccess` (+3 -0) ➖ `bower.json` (+0 -27) 📝 `config/app.php` (+1 -1) 📝 `gulpfile.js` (+1 -1) 📝 `package.json` (+2 -1) 📝 `resources/assets/js/components/site-footer/index.vue` (+4 -3) 📝 `resources/assets/js/services/playback.js` (+6 -2) 📝 `resources/assets/sass/app.scss` (+1 -1) 📝 `resources/assets/sass/vendor/_plyr.scss` (+308 -249) </details> ### 📄 Description Hey, I discovered this app recently and I love it. Thought I could help. This should close #227 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 02:35:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1187
No description provided.