[PR #118] [CLOSED] Fix song length issue #1159

New issue

Closed

opened 2026-02-26 02:35:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 02:35:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/118
Author: @mattsches
Created: 12/19/2015
Status: ❌ Closed

Base: master ← Head: fix_album_length

📝 Commits (7)

7dde350 Added spanish validations
2cf325e Fixed composer --no-dev issue
b293160 Attempts to fix UTF-16 issues
6a428ea Applied fixes from StyleCI
255776b Replace iconv with mb_
14f26ba Fix spelling error for password
451dd12 Add cast to convert Song.length to float.

📊 Changes

14 files changed (+289 additions, -11 deletions)

View changed files

📝 .env.example (+1 -1)
➕ app/Facades/Util.php (+13 -0)
📝 app/Models/Artist.php (+8 -0)
📝 app/Models/Song.php (+7 -0)
➕ app/Providers/UtilServiceProvider.php (+31 -0)
➕ app/Services/Util.php (+46 -0)
📝 composer.json (+4 -4)
📝 config/app.php (+2 -0)
➕ resources/lang/es/auth.php (+19 -0)
➕ resources/lang/es/pagination.php (+19 -0)
➕ resources/lang/es/passwords.php (+22 -0)
➕ resources/lang/es/validation.php (+112 -0)
📝 tests/ArtistTest.php (+5 -6)
➕ tests/stubs/utf16 (+0 -0)

📄 Description

Laravel's Eloquent ORM returns all properties as strings unless explicitly casting them to other types. Song.length is now cast to float.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/118 **Author:** [@mattsches](https://github.com/mattsches) **Created:** 12/19/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_album_length` --- ### 📝 Commits (7) - [`7dde350`](https://github.com/koel/koel/commit/7dde350840530de52c596c4441be40989ad53b58) Added spanish validations - [`2cf325e`](https://github.com/koel/koel/commit/2cf325e8ae00062789a7610ac6657f3bbdce25a0) Fixed composer --no-dev issue - [`b293160`](https://github.com/koel/koel/commit/b293160beda2a02aa3837c777c5a0feb840bdc84) Attempts to fix UTF-16 issues - [`6a428ea`](https://github.com/koel/koel/commit/6a428ead895e204b9b79e40a6e9c329fd7801258) Applied fixes from StyleCI - [`255776b`](https://github.com/koel/koel/commit/255776b014fd1022ec030b79d621cf17eacfa61d) Replace iconv with mb_ - [`14f26ba`](https://github.com/koel/koel/commit/14f26ba0c5fc6b665261892a9419e1e27f04fe03) Fix spelling error for password - [`451dd12`](https://github.com/koel/koel/commit/451dd12cf676185d8e2a2b977ac17e8f13208870) Add cast to convert Song.length to float. ### 📊 Changes **14 files changed** (+289 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+1 -1) ➕ `app/Facades/Util.php` (+13 -0) 📝 `app/Models/Artist.php` (+8 -0) 📝 `app/Models/Song.php` (+7 -0) ➕ `app/Providers/UtilServiceProvider.php` (+31 -0) ➕ `app/Services/Util.php` (+46 -0) 📝 `composer.json` (+4 -4) 📝 `config/app.php` (+2 -0) ➕ `resources/lang/es/auth.php` (+19 -0) ➕ `resources/lang/es/pagination.php` (+19 -0) ➕ `resources/lang/es/passwords.php` (+22 -0) ➕ `resources/lang/es/validation.php` (+112 -0) 📝 `tests/ArtistTest.php` (+5 -6) ➕ `tests/stubs/utf16` (+0 -0) </details> ### 📄 Description Laravel's Eloquent ORM returns all properties as strings unless explicitly casting them to other types. `Song.length` is now cast to `float`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 02:35:39 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:31:40 +03:00

[PR #1159] [CLOSED] [NEW] - Implements TranscodingService Test #1610

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1159

No description provided.

Rows
Columns