[PR #76] [CLOSED] Queue media sync when media path is set #1146

New issue

Closed

opened 2026-02-26 02:35:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 02:35:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/76
Author: @pedroborges
Created: 12/16/2015
Status: ❌ Closed

Base: master ← Head: MediaPathChanged-event

📝 Commits (2)

06de89b Queue media sync when media path is set
c5edffa Applied suggestions from StyleCI

📊 Changes

5 files changed (+69 additions, -7 deletions)

View changed files

➕ app/Events/MediaPathChanged.php (+25 -0)
📝 app/Http/Controllers/API/SettingController.php (+2 -4)
➕ app/Listeners/SyncMediaListener.php (+22 -0)
📝 app/Providers/EventServiceProvider.php (+2 -2)
📝 tests/SettingTest.php (+18 -1)

📄 Description

Another commit motivated by a comment:

// In a next version we should opt for a "MediaPathChanged" event,
// but let's just do this async now.

I've included a test for this and manually tested also. Works fine on my end. Let me know is there are any changes you want me to make.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/76 **Author:** [@pedroborges](https://github.com/pedroborges) **Created:** 12/16/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `MediaPathChanged-event` --- ### 📝 Commits (2) - [`06de89b`](https://github.com/koel/koel/commit/06de89b51b854a88d270b1aa94d699c893a4a901) Queue media sync when media path is set - [`c5edffa`](https://github.com/koel/koel/commit/c5edffa07f08f201478de2f7cf6788b03f7bba00) Applied suggestions from StyleCI ### 📊 Changes **5 files changed** (+69 additions, -7 deletions) <details> <summary>View changed files</summary> ➕ `app/Events/MediaPathChanged.php` (+25 -0) 📝 `app/Http/Controllers/API/SettingController.php` (+2 -4) ➕ `app/Listeners/SyncMediaListener.php` (+22 -0) 📝 `app/Providers/EventServiceProvider.php` (+2 -2) 📝 `tests/SettingTest.php` (+18 -1) </details> ### 📄 Description Another commit motivated by a comment: ``` // In a next version we should opt for a "MediaPathChanged" event, // but let's just do this async now. ``` I've included a test for this and manually tested also. Works fine on my end. Let me know is there are any changes you want me to make. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 02:35:36 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:31:38 +03:00

[PR #1146] [MERGED] chore(deps): bump fideloper/proxy from 4.2.1 to 4.2.2 #1605

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1146

No description provided.

Rows
Columns