[PR #44] [CLOSED] Move index.php to /public. Fixes #40. #1138

New issue

Closed

opened 2026-02-26 02:35:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 02:35:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/44
Author: @cgrossde
Created: 12/14/2015
Status: ❌ Closed

Base: master ← Head: cover-fix

📝 Commits (1)

c087366 Move index.php to /public. Fixes #40.

📊 Changes

6 files changed (+16 additions, -11 deletions)

View changed files

📝 .gitignore (+6 -1)
📝 app/Models/Album.php (+2 -2)
📝 gulpfile.js (+1 -1)
📝 public/.htaccess (+0 -0)
📝 public/index.php (+2 -2)
📝 resources/views/index.blade.php (+5 -5)

📄 Description

Currently the webroot is within the applications root (/). This leads to #40 because Laravel thinks the /public folder is in /not /public. This PR move the index.php and .htaccess back to /public. This is also preferred by vanilla Laravel: https://github.com/laravel/laravel/tree/master/public

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/44 **Author:** [@cgrossde](https://github.com/cgrossde) **Created:** 12/14/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cover-fix` --- ### 📝 Commits (1) - [`c087366`](https://github.com/koel/koel/commit/c087366c2c16432a7bb59029b749cd7c6ec1e013) Move index.php to /public. Fixes #40. ### 📊 Changes **6 files changed** (+16 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+6 -1) 📝 `app/Models/Album.php` (+2 -2) 📝 `gulpfile.js` (+1 -1) 📝 `public/.htaccess` (+0 -0) 📝 `public/index.php` (+2 -2) 📝 `resources/views/index.blade.php` (+5 -5) </details> ### 📄 Description Currently the webroot is within the applications root (`/`). This leads to #40 because Laravel thinks the `/public` folder is in `/`not `/public`. This PR move the `index.php` and `.htaccess` back to `/public`. This is also preferred by vanilla Laravel: https://github.com/laravel/laravel/tree/master/public --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 02:35:34 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:31:37 +03:00

[PR #1138] [MERGED] chore(deps-dev): bump phpunit/phpunit from 7.5.17 to 7.5.18 #1600

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1138

No description provided.

Rows
Columns