[PR #35] [MERGED] Add case insensitive order by for list views #1134

New issue

Closed

opened 2026-02-26 02:35:33 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 02:35:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/35
Author: @mattstauffer
Created: 12/14/2015
Status: ✅ Merged
Merged: 12/15/2015
Merged by: @phanan

Base: master ← Head: case-insensitive-order

📝 Commits (2)

be003e2 Add case insensitive order by for list views
90250eb Convert case-insensitive sort to use core Vue methods

📊 Changes

2 files changed (+23 additions, -1 deletions)

View changed files

📝 resources/assets/js/app.vue (+22 -0)
📝 resources/assets/js/components/shared/song-list.vue (+1 -1)

📄 Description

Prior to this PR being merged, the orderBy for columns is case sensitive. That means my list places lowercased-artist mewithoutyou after the entire list of Title-cased artists.

After the change:

Heavy caveat: the hacked functions that I stole from Vue core are not quite as good as the core versions, but I couldn't figure out how to import core Vue functions. Maybe it's possible?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/35 **Author:** [@mattstauffer](https://github.com/mattstauffer) **Created:** 12/14/2015 **Status:** ✅ Merged **Merged:** 12/15/2015 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `case-insensitive-order` --- ### 📝 Commits (2) - [`be003e2`](https://github.com/koel/koel/commit/be003e2966d763e9b476e09ebe662a82993b27a6) Add case insensitive order by for list views - [`90250eb`](https://github.com/koel/koel/commit/90250eb337f6a32b7ae57ed492859b57f90af70f) Convert case-insensitive sort to use core Vue methods ### 📊 Changes **2 files changed** (+23 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/app.vue` (+22 -0) 📝 `resources/assets/js/components/shared/song-list.vue` (+1 -1) </details> ### 📄 Description Prior to this PR being merged, the `orderBy` for columns is case sensitive. That means my list places lowercased-artist `mewithoutyou` after the entire list of Title-cased artists. ![image](https://cloud.githubusercontent.com/assets/151829/11790689/18538858-a26b-11e5-8b02-8871d72167b9.png) After the change: ![image](https://cloud.githubusercontent.com/assets/151829/11790741/529ae47a-a26b-11e5-865a-fca6dd7d4060.png) Heavy caveat: the hacked functions that I stole from Vue core are not quite as good as the core versions, but I couldn't figure out how to import core Vue functions. Maybe it's possible? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 02:35:33 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1134

No description provided.

Rows
Columns