mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #162] Music not playing with x-sendfile option #112
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#112
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ronilaukkarinen on GitHub (Dec 29, 2015).
Original GitHub issue: https://github.com/koel/koel/issues/162
For some reason I cannot play anything with
STREAMING_METHOD=x-sendfile.My httpd.conf part:
Google Chrome console:
With
STREAMING_METHOD=phpeverything plays perfectly well. I'm using the latest 1.1.2.@phanan commented on GitHub (Dec 30, 2015):
Should be
<IfModule mod_xsendfile.c>instead.@ronilaukkarinen commented on GitHub (Dec 30, 2015):
This should be fixed in the Wiki?
@ronilaukkarinen commented on GitHub (Dec 30, 2015):
Corrected my httpd.conf and restarted apache. Still geting the same error. Should I recompile koel after this? That module should be OK, I don't get any errors on apache's side.
@phanan commented on GitHub (Dec 30, 2015):
I can't recall documenting this in wiki? Koel doesnt need to be recompiled, either.
@ronilaukkarinen commented on GitHub (Dec 30, 2015):
@phanan It is, here. I don't get why it doesn't work. Is there true advantages in x-sendfile, faster perhaps? I'm forced to use php for now because it just works.
@phanan commented on GitHub (Dec 31, 2015):
Oops. Thanks for pointing it out.
Check the XSendFilePath variable maybe? I'd even remove the
directive, just to make sure.
Yes.
On Thu, Dec 31, 2015 at 1:20 AM, Roni Laukkarinen notifications@github.com
wrote:
@ronilaukkarinen commented on GitHub (Jan 22, 2016):
I tested this again without . It seems the only way to get this to work is to add
XSendFilePath /, notXSendFilePath /var/wwworXSendFilePath /var/www/html/koel, because for some reason it won't find /api if set that way. Is settingXSendFilePath /very safe?@triDcontrols commented on GitHub (Jul 21, 2017):
@ronilaukkarinen What prompted you to switch to x-sendfile? I'm having an issue with the slow responsiveness of the Koel UI and music stuttering in mobile chrome browser. Wanting to try x-sendfile but in the same boat as you as far as security is concerned, leaving Xsendfile to /.
@ronilaukkarinen commented on GitHub (Jul 26, 2017):
@tridiumcontrols Tried it out based on the docs (it's supposed to be faster) and instructions @phanan gave me (two comments up), nothing else particular prompted me to the 'switch'.
@Sp1l commented on GitHub (Jun 4, 2024):
Not sure, but that would allow an attacker to read any file from your filesystem.
You can achieve the same without mod_xsendfile:
@phanan commented on GitHub (Jun 4, 2024):
@Sp1l When you say "You can achieve the same without mod_xsendfile," do you mean the streaming will work exactly like with the module without the need to install it?
@Sp1l commented on GitHub (Jun 4, 2024):
Scrap all of it, that's not what it does.
@phanan commented on GitHub (Jun 4, 2024):
TIL, thanks! I'll give it a go and update the docs for v7, which is coming very close :)
@Sp1l commented on GitHub (Jun 4, 2024):
Sorry... My bad. The x-sendfile is in the RESPONSE, not in the request
@phanan commented on GitHub (Jun 4, 2024):
Not sure I follow. Do you mean it doesn't work?
@Sp1l commented on GitHub (Jun 4, 2024):
Correct, it does not work.