starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-26 17:25:59 +03:00

[GH-ISSUE #159] Ask confirmation before closing tab #111

New issue

Closed

opened 2026-02-26 02:32:10 +03:00 by kerem · 8 comments

kerem commented

2026-02-26 02:32:10 +03:00

Owner

Originally created by @Beanow on GitHub (Dec 29, 2015).
Original GitHub issue: https://github.com/koel/koel/issues/159

Like this, http://jsfiddle.net/gopi1410/yWs7P/

When music is still playing it would be nice to close it only after confirmation.

Originally created by @Beanow on GitHub (Dec 29, 2015). Original GitHub issue: https://github.com/koel/koel/issues/159 Like this, http://jsfiddle.net/gopi1410/yWs7P/ When music is still playing it would be nice to close it only after confirmation.

kerem closed this issue

2026-02-26 02:32:10 +03:00

kerem commented

2026-02-26 02:32:10 +03:00

Author

Owner

@phanan commented on GitHub (Dec 30, 2015):

Personally I'm against this idea. This only adds one extra step to close a tab, with no gain – we're not losing anything without the confirmation.

@phanan commented on GitHub (Dec 30, 2015): Personally I'm against this idea. This only adds one extra step to close a tab, with no gain – we're not losing anything without the confirmation.

kerem commented

2026-02-26 02:32:10 +03:00

Author

Owner

@Beanow commented on GitHub (Dec 30, 2015):

What you lose is, your music gets stopped and your current queue as well. Suppose you're at the office and playing on the big speakers for 10 people. During your work you close the browser, overlooking the tiny pinned tab for koel and there you have an eerie silence.

Currently I don't use other services to compare this with, but it was present on Grooveshark and was a feature I much enjoyed.

@Beanow commented on GitHub (Dec 30, 2015): What you lose is, your music gets stopped and your current queue as well. Suppose you're at the office and playing on the big speakers for 10 people. During your work you close the browser, overlooking the tiny pinned tab for koel and there you have an eerie silence. Currently I don't use other services to compare this with, but it was present on Grooveshark and was a feature I much enjoyed.

kerem commented

2026-02-26 02:32:10 +03:00

Author

Owner

@phanan commented on GitHub (Dec 31, 2015):

Yours is an edge case I think. I'm reopening this though, to see if what the community think. I vote 👎 personally.

@phanan commented on GitHub (Dec 31, 2015): Yours is an edge case I think. I'm reopening this though, to see if what the community think. I vote :-1: personally.

kerem commented

2026-02-26 02:32:10 +03:00

Author

Owner

@Beanow commented on GitHub (Jan 4, 2016):

The situation is just for illustration. As a general rule I do prefer to have a confirmation popup over the music stopping.

(👍)

@Beanow commented on GitHub (Jan 4, 2016): The situation is just for illustration. As a general rule I do prefer to have a confirmation popup over the music stopping. (:+1:)

kerem commented

2026-02-26 02:32:10 +03:00

Author

Owner

@phanan commented on GitHub (Jan 4, 2016):

Or, it can be a setting, just saying.

@phanan commented on GitHub (Jan 4, 2016): Or, it can be a setting, just saying.

kerem commented

2026-02-26 02:32:10 +03:00

Author

Owner

@charles-toller commented on GitHub (Jan 9, 2016):

Perhaps a preference pane thing? A toggle for confirmation before closing koel?

@charles-toller commented on GitHub (Jan 9, 2016): Perhaps a preference pane thing? A toggle for confirmation before closing koel?

kerem commented

2026-02-26 02:32:10 +03:00

Author

Owner

@rohanpandula commented on GitHub (Jan 10, 2016):

(👍) for the toggle

@rohanpandula commented on GitHub (Jan 10, 2016): (:+1:) for the toggle

kerem commented

2026-02-26 02:32:10 +03:00

Author

Owner

@phanan commented on GitHub (Jan 12, 2016):

Implemented on 2.0 branch.

@phanan commented on GitHub (Jan 12, 2016): Implemented on `2.0` branch.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#111

No description provided.

Rows
Columns