[PR #140] feature: #130 - Shows missing songs in albums, including preview #21

Open
opened 2026-03-07 19:53:29 +03:00 by kerem · 0 comments
Owner

Original Pull Request: https://github.com/Chevron7Locked/kima-hub/pull/140

State: open
Merged: No


Description

Adds missing tracks to albums as previews - meaning that track numbers line up correctly for albums.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Enhancement (improvement to existing functionality)
  • Documentation update
  • Code cleanup / refactoring
  • Other (please describe):

Fixes #130

Changes Made

  • Build album track list, get deezer previews for missing tracks
  • Insert missing tracks at their correct album track number
  • End preview audio cleanly to remove spurious Failed to play preview message

Testing Done

  • Tested locally with Docker
  • Tested specific functionality:
  • Validated tracks are in correct order
  • Validated missing tracks at start and end of album show up
  • Validated missing tracks in middle of album show up
  • Validated preview tracks worked

Screenshots (if applicable)

Before:
Screenshot 2026-03-01 214918
After:
Screenshot 2026-03-01 215336

Checklist

  • My code follows the project's code style
  • I have tested my changes locally
  • I have updated documentation if needed
  • My changes don't introduce new warnings
  • This PR targets the main branch
**Original Pull Request:** https://github.com/Chevron7Locked/kima-hub/pull/140 **State:** open **Merged:** No --- ## Description Adds missing tracks to albums as previews - meaning that track numbers line up correctly for albums. ## Type of Change - [ ] Bug fix (non-breaking change that fixes an issue) - [ ] New feature (non-breaking change that adds functionality) - [X] Enhancement (improvement to existing functionality) - [ ] Documentation update - [ ] Code cleanup / refactoring - [ ] Other (please describe): ## Related Issues Fixes #130 ## Changes Made - Build album track list, get deezer previews for missing tracks - Insert missing tracks at their correct album track number - End preview audio cleanly to remove spurious Failed to play preview message ## Testing Done - [X] Tested locally with Docker - [X] Tested specific functionality: - Validated tracks are in correct order - Validated missing tracks at start and end of album show up - Validated missing tracks in middle of album show up - Validated preview tracks worked ## Screenshots (if applicable) Before: <img width="415" height="331" alt="Screenshot 2026-03-01 214918" src="https://github.com/user-attachments/assets/5e19badf-833c-4191-b320-16218a3434eb" /> After: <img width="1343" height="353" alt="Screenshot 2026-03-01 215336" src="https://github.com/user-attachments/assets/07f7d8a6-db97-41c5-a5df-6cc6ecc9d781" /> ## Checklist - [X] My code follows the project's code style - [X] I have tested my changes locally - [X] I have updated documentation if needed - [X] My changes don't introduce new warnings - [X] This PR targets the `main` branch
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/kima-hub#21
No description provided.