[GH-ISSUE #1402] Add a bookmark to a list API should be idempotent #889

Closed
opened 2026-03-02 11:53:32 +03:00 by kerem · 5 comments
Owner

Originally created by @hasansino on GitHub (May 14, 2025).
Original GitHub issue: https://github.com/karakeep-app/karakeep/issues/1402

Originally assigned to: @xuatz on GitHub.

Adding bookmark to the list where it is already present returns 400 error, which prevents (or at least makes it more complicated) for exporters to work.

Originally created by @hasansino on GitHub (May 14, 2025). Original GitHub issue: https://github.com/karakeep-app/karakeep/issues/1402 Originally assigned to: @xuatz on GitHub. Adding bookmark to the list where it is already present returns 400 error, which prevents (or at least makes it more complicated) for exporters to work.
Author
Owner

@xuatz commented on GitHub (May 17, 2025):

@MohamedBassem It sounds like this can/should be handled together with #864?

I could pick them both up too.

<!-- gh-comment-id:2888235996 --> @xuatz commented on GitHub (May 17, 2025): @MohamedBassem It sounds like this can/should be handled together with #864? I could pick them both up too.
Author
Owner

@MohamedBassem commented on GitHub (May 17, 2025):

@xuatz This and #864 are a bit different in my opinion. If you're interesting in working on it, I can assign it to you :)

<!-- gh-comment-id:2888261709 --> @MohamedBassem commented on GitHub (May 17, 2025): @xuatz This and #864 are a bit different in my opinion. If you're interesting in working on it, I can assign it to you :)
Author
Owner

@xuatz commented on GitHub (May 17, 2025):

@xuatz This and #864 are a bit different in my opinion. If you're interesting in working on it, I can assign it to you :)

if we have some leeway on timeline then sure 💪

<!-- gh-comment-id:2888282232 --> @xuatz commented on GitHub (May 17, 2025): > @xuatz This and #864 are a bit different in my opinion. If you're interesting in working on it, I can assign it to you :) if we have some leeway on timeline then sure 💪
Author
Owner

@xuatz commented on GitHub (May 17, 2025):

@xuatz This and #864 are a bit different in my opinion. If you're interesting in working on it, I can assign it to you :)

@MohamedBassem ohhhh somehow in my mind I thought this issue was referring to
PUT /api/v1/bookmarks/:id 😅

<!-- gh-comment-id:2888450877 --> @xuatz commented on GitHub (May 17, 2025): > [@xuatz](https://github.com/xuatz) This and [#864](https://github.com/karakeep-app/karakeep/issues/864) are a bit different in my opinion. If you're interesting in working on it, I can assign it to you :) @MohamedBassem ohhhh somehow in my mind I thought this issue was referring to PUT `/api/v1/bookmarks/:id` 😅
Author
Owner

@MohamedBassem commented on GitHub (May 17, 2025):

@xuatz this is a much simpler one. Just this endpoint (https://docs.karakeep.app/API/add-a-bookmark-to-a-list) needs to not fail when the item is already in the list.

<!-- gh-comment-id:2888452906 --> @MohamedBassem commented on GitHub (May 17, 2025): @xuatz this is a much simpler one. Just this endpoint (https://docs.karakeep.app/API/add-a-bookmark-to-a-list) needs to not fail when the item is already in the list.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#889
No description provided.