[GH-ISSUE #846] Copy Link menu in bookmark options is not greyed out when clipboard is not available #554

Closed
opened 2026-03-02 11:50:49 +03:00 by kerem · 2 comments
Owner

Originally created by @esteve88 on GitHub (Jan 7, 2025).
Original GitHub issue: https://github.com/karakeep-app/karakeep/issues/846

Describe the Bug

The context menu called "Copy Link" (which is supposed to copy the link attached to the note) is not working. If it is clicked, then nothing happens (and the context menu does not disappear).

Steps to Reproduce

  1. Create a new note providing a link to an external website
  2. Click on the three dots in the bottom right part of the tile and select "Copy Link"

Expected Behaviour

The link is copied into the clipboard (and the context menu disappears)

Screenshots or Additional Context

This issue seems to be due to an issue in Javascript. See below the error which is raised in JS when the "Copy Link" button is pressed:

image

Device Details

Google Chrome on Windows Client

Exact Hoarder Version

v0.21.0

Have you checked the troubleshooting guide?

  • I have checked the troubleshooting guide and I haven't found a solution to my problem
Originally created by @esteve88 on GitHub (Jan 7, 2025). Original GitHub issue: https://github.com/karakeep-app/karakeep/issues/846 ### Describe the Bug The context menu called "Copy Link" (which is supposed to copy the link attached to the note) is not working. If it is clicked, then nothing happens (and the context menu does not disappear). ### Steps to Reproduce 1. Create a new note providing a link to an external website 2. Click on the three dots in the bottom right part of the tile and select "Copy Link" ### Expected Behaviour The link is copied into the clipboard (and the context menu disappears) ### Screenshots or Additional Context This issue seems to be due to an issue in Javascript. See below the error which is raised in JS when the "Copy Link" button is pressed: ![image](https://github.com/user-attachments/assets/fffbb8d9-42a3-440e-ae77-615d0e0dda8a) ### Device Details Google Chrome on Windows Client ### Exact Hoarder Version v0.21.0 ### Have you checked the troubleshooting guide? - [X] I have checked the troubleshooting guide and I haven't found a solution to my problem
Author
Owner

@kamtschatka commented on GitHub (Jan 7, 2025):

are you on http by chance?
clipboard does not work on http (browser limitation, so nothing hoarder can fix).
But the button should be disabled in that case, so that would be a bug in hoarder.

<!-- gh-comment-id:2576374321 --> @kamtschatka commented on GitHub (Jan 7, 2025): are you on http by chance? clipboard does not work on http (browser limitation, so nothing hoarder can fix). But the button should be disabled in that case, so that would be a bug in hoarder.
Author
Owner

@esteve88 commented on GitHub (Jan 8, 2025):

Thanks for the heads up! Yes I confirm I was using HTTP; I tried now reaching Hoarder through HTTPS and indeed the copy link works correctly.
As you mentioned it would then be good to remove the copy link functionality when in HTTP to avoid confusion or errors in JS (making it greyed out could be another option though 😃 ).

<!-- gh-comment-id:2577108725 --> @esteve88 commented on GitHub (Jan 8, 2025): Thanks for the heads up! Yes I confirm I was using HTTP; I tried now reaching Hoarder through HTTPS and indeed the copy link works correctly. As you mentioned it would then be good to remove the copy link functionality when in HTTP to avoid confusion or errors in JS (making it greyed out could be another option though 😃 ).
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#554
No description provided.