[GH-ISSUE #30] Dark mode support in Firefox extension #26

Closed
opened 2026-03-02 11:45:49 +03:00 by kerem · 8 comments
Owner

Originally created by @vercas on GitHub (Mar 27, 2024).
Original GitHub issue: https://github.com/karakeep-app/karakeep/issues/30

This is what it currently looks like when bookmarking a page:
Screenshot 2024-03-27 at 17 22 09

Originally created by @vercas on GitHub (Mar 27, 2024). Original GitHub issue: https://github.com/karakeep-app/karakeep/issues/30 This is what it currently looks like when bookmarking a page: <img width="393" alt="Screenshot 2024-03-27 at 17 22 09" src="https://github.com/MohamedBassem/hoarder-app/assets/1823741/f35a4190-2d19-4294-b9e5-196516873dac">
kerem 2026-03-02 11:45:49 +03:00
Author
Owner

@MohamedBassem commented on GitHub (Mar 27, 2024):

That looks ugly indeed, will fix it :)

<!-- gh-comment-id:2023368798 --> @MohamedBassem commented on GitHub (Mar 27, 2024): That looks ugly indeed, will fix it :)
Author
Owner

@JFPCreations commented on GitHub (Mar 27, 2024):

+1
I was about to post the same but for chrome extension in Brave. ;)
Because of dark theme the popup is looking weird.

brave_hrWgny1hWV
mxEpIQ7DKR

<!-- gh-comment-id:2023395891 --> @JFPCreations commented on GitHub (Mar 27, 2024): +1 I was about to post the same but for chrome extension in Brave. ;) Because of dark theme the popup is looking weird. ![brave_hrWgny1hWV](https://github.com/MohamedBassem/hoarder-app/assets/10256543/4b0b4356-937e-47db-8805-cd7338d2a45e) ![mxEpIQ7DKR](https://github.com/MohamedBassem/hoarder-app/assets/10256543/65495ebf-9921-4125-a824-b7c9385d2c86)
Author
Owner

@MohamedBassem commented on GitHub (Mar 27, 2024):

I'm actually, curious, how did you get to have dark mode in the extension popup. It seems that for me, it's always in light mode regardless of what my theme color is :D Are you using any plugin that forces dark mode in websites or something?

EDIT: Oh, nvm. It's in dark mode when the system itself is in dark mode. Managed to repro.

<!-- gh-comment-id:2023417749 --> @MohamedBassem commented on GitHub (Mar 27, 2024): I'm actually, curious, how did you get to have dark mode in the extension popup. It seems that for me, it's always in light mode regardless of what my theme color is :D Are you using any plugin that forces dark mode in websites or something? EDIT: Oh, nvm. It's in dark mode when the system itself is in dark mode. Managed to repro.
Author
Owner

@MohamedBassem commented on GitHub (Mar 27, 2024):

Thanks for the report, I think it looks slightly nicer now. Will be available in the next extension release.

Screenshot 2024-03-27 at 5 58 03 PM
<!-- gh-comment-id:2023447971 --> @MohamedBassem commented on GitHub (Mar 27, 2024): Thanks for the report, I think it looks slightly nicer now. Will be available in the next extension release. <img width="384" alt="Screenshot 2024-03-27 at 5 58 03 PM" src="https://github.com/MohamedBassem/hoarder-app/assets/2418637/1b2402e8-c4aa-4eb7-9c0d-de3271f0b0f8">
Author
Owner

@JFPCreations commented on GitHub (Mar 27, 2024):

Thank you for this fast work. Did you or can you add a white icon the the dark theme?
image

<!-- gh-comment-id:2023468070 --> @JFPCreations commented on GitHub (Mar 27, 2024): Thank you for this fast work. Did you or can you add a white icon the the dark theme? ![image](https://github.com/MohamedBassem/hoarder-app/assets/10256543/c7f2800b-b326-4aad-a3c0-f229c0bd46b0)
Author
Owner

@MohamedBassem commented on GitHub (Mar 27, 2024):

I don't think I can customize the icon based on wether it's light mode or dark mode. I checked and chrome developer's guide suggestion is to add a subtle white glow around the logo to make it visible in dark mode. Let me do that.

<!-- gh-comment-id:2024124712 --> @MohamedBassem commented on GitHub (Mar 27, 2024): I don't think I can customize the icon based on wether it's light mode or dark mode. I checked and chrome developer's guide suggestion is to add a subtle white glow around the logo to make it visible in dark mode. Let me do that.
Author
Owner

@vercas commented on GitHub (Mar 27, 2024):

This extension switches its toolbar icon in Firefox: https://github.com/Mika-/torrent-control

<!-- gh-comment-id:2024130763 --> @vercas commented on GitHub (Mar 27, 2024): This extension switches its toolbar icon in Firefox: https://github.com/Mika-/torrent-control
Author
Owner

@JFPCreations commented on GitHub (Apr 2, 2024):

I think you have upgraded the extension.

It is viewable now.

image

Thank you.

<!-- gh-comment-id:2033190517 --> @JFPCreations commented on GitHub (Apr 2, 2024): I think you have upgraded the extension. It is viewable now. ![image](https://github.com/MohamedBassem/hoarder-app/assets/10256543/88252fe4-acd2-47ec-85c2-191f4b10e6d8) Thank you.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#26
No description provided.