[PR #2549] feat: separate manually added bookmarks from RSS subscriptions in UI and rules #2158

New issue

Open

opened 2026-03-02 12:00:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 12:00:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/2549
Author: @VedantMadane
Created: 3/2/2026
Status: 🔄 Open

Base: main ← Head: feat/separate-manual-and-rss-bookmarks

📝 Commits (4)

8970dee fix: cleanup orphaned assets if crawler crashes before database transaction commits
f188670 feat: separate manually added bookmarks from RSS subscriptions in UI and rules
cbfeeb6 Update apps/web/components/dashboard/rules/RuleEngineConditionBuilder.tsx
4e0cd2e Update apps/web/components/dashboard/bookmarks/BookmarkLayoutAdaptingCard.tsx

📊 Changes

6 files changed (+444 additions, -282 deletions)

View changed files

📝 apps/web/components/dashboard/bookmarks/BookmarkLayoutAdaptingCard.tsx (+40 -0)
📝 apps/web/components/dashboard/rules/RuleEngineConditionBuilder.tsx (+54 -0)
📝 apps/web/lib/i18n/locales/en/translation.json (+12 -2)
📝 apps/workers/workers/crawlerWorker.ts (+318 -280)
📝 packages/shared/types/rules.ts (+17 -0)
📝 packages/trpc/lib/ruleEngine.ts (+3 -0)

📄 Description

Fixes #2526.

Summary

This PR adds the ability to distinguish between manually added bookmarks and those received via RSS subscriptions, both visually and through automated rules.

Key Changes:

Rule Engine: Added a new \ookmarkSourceIs\ condition, allowing users to automate actions based on where a bookmark came from (e.g., tagging all RSS items).
UI Indicators: Added a \SourceIndicator\ to \BookmarkLayoutAdaptingCard. RSS bookmarks now show an orange RSS icon, while manual bookmarks (Web, Extension, Mobile, CLI) show a blue pointer icon.
Search Support: The search parser already supported \source:\ filters (e.g., \source:rss), which now work seamlessly with these improvements.
Localization: Added new translation strings for bookmark sources in \ ranslation.json.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/2549 **Author:** [@VedantMadane](https://github.com/VedantMadane) **Created:** 3/2/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/separate-manual-and-rss-bookmarks` --- ### 📝 Commits (4) - [`8970dee`](https://github.com/karakeep-app/karakeep/commit/8970dee633cbb12227ab49d01a7c33cdb4b79cc4) fix: cleanup orphaned assets if crawler crashes before database transaction commits - [`f188670`](https://github.com/karakeep-app/karakeep/commit/f18867062bc58907276d547e120a182f0931a677) feat: separate manually added bookmarks from RSS subscriptions in UI and rules - [`cbfeeb6`](https://github.com/karakeep-app/karakeep/commit/cbfeeb670f53b42d9e305afad8af7d97ac23b509) Update apps/web/components/dashboard/rules/RuleEngineConditionBuilder.tsx - [`4e0cd2e`](https://github.com/karakeep-app/karakeep/commit/4e0cd2e44f02ee4f4b3904ea68e358049a1821df) Update apps/web/components/dashboard/bookmarks/BookmarkLayoutAdaptingCard.tsx ### 📊 Changes **6 files changed** (+444 additions, -282 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/components/dashboard/bookmarks/BookmarkLayoutAdaptingCard.tsx` (+40 -0) 📝 `apps/web/components/dashboard/rules/RuleEngineConditionBuilder.tsx` (+54 -0) 📝 `apps/web/lib/i18n/locales/en/translation.json` (+12 -2) 📝 `apps/workers/workers/crawlerWorker.ts` (+318 -280) 📝 `packages/shared/types/rules.ts` (+17 -0) 📝 `packages/trpc/lib/ruleEngine.ts` (+3 -0) </details> ### 📄 Description Fixes #2526. ### Summary This PR adds the ability to distinguish between manually added bookmarks and those received via RSS subscriptions, both visually and through automated rules. ### Key Changes: - **Rule Engine:** Added a new \ookmarkSourceIs\ condition, allowing users to automate actions based on where a bookmark came from (e.g., tagging all RSS items). - **UI Indicators:** Added a \SourceIndicator\ to \BookmarkLayoutAdaptingCard\. RSS bookmarks now show an orange RSS icon, while manual bookmarks (Web, Extension, Mobile, CLI) show a blue pointer icon. - **Search Support:** The search parser already supported \source:\ filters (e.g., \source:rss\), which now work seamlessly with these improvements. - **Localization:** Added new translation strings for bookmark sources in \ ranslation.json\. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-03-02 12:00:47 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#2158

No description provided.

Rows
Columns