[PR #2547] feat: support bookmark source condition in rule engine (#2526) #2155

New issue

Open

opened 2026-03-02 12:00:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 12:00:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/2547
Author: @xingzihai
Created: 3/2/2026
Status: 🔄 Open

Base: main ← Head: feat/2526-bookmark-source-rule

📝 Commits (1)

bbdcf10 feat(rule-engine): support bookmark source condition (#2526)

📊 Changes

5 files changed (+67 additions, -0 deletions)

View changed files

📝 apps/web/components/dashboard/rules/RuleEngineConditionBuilder.tsx (+36 -0)
📝 apps/web/lib/i18n/locales/en/translation.json (+1 -0)
📝 packages/shared/types/rules.ts (+10 -0)
📝 packages/trpc/lib/__tests__/ruleEngine.test.ts (+17 -0)
📝 packages/trpc/lib/ruleEngine.ts (+3 -0)

📄 Description

Summary`n- add bookmarkSourceIs rule condition`n- evaluate bookmark source in trpc rule engine`n- expose source condition in web rule builder`n- add tests`n`n## Verification`n- pnpm -C karakeep --filter @karakeep/trpc test -- --run lib/tests/ruleEngine.test.ts`n- pnpm -C karakeep --filter @karakeep/trpc typecheck`n- pnpm -C karakeep --filter @karakeep/web typecheck`n`nCloses #2526

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/2547 **Author:** [@xingzihai](https://github.com/xingzihai) **Created:** 3/2/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/2526-bookmark-source-rule` --- ### 📝 Commits (1) - [`bbdcf10`](https://github.com/karakeep-app/karakeep/commit/bbdcf106f0269c6132d2a9645e7c506650fe637b) feat(rule-engine): support bookmark source condition (#2526) ### 📊 Changes **5 files changed** (+67 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/components/dashboard/rules/RuleEngineConditionBuilder.tsx` (+36 -0) 📝 `apps/web/lib/i18n/locales/en/translation.json` (+1 -0) 📝 `packages/shared/types/rules.ts` (+10 -0) 📝 `packages/trpc/lib/__tests__/ruleEngine.test.ts` (+17 -0) 📝 `packages/trpc/lib/ruleEngine.ts` (+3 -0) </details> ### 📄 Description ## Summary`n- add bookmarkSourceIs rule condition`n- evaluate bookmark source in trpc rule engine`n- expose source condition in web rule builder`n- add tests`n`n## Verification`n- pnpm -C karakeep --filter @karakeep/trpc test -- --run lib/__tests__/ruleEngine.test.ts`n- pnpm -C karakeep --filter @karakeep/trpc typecheck`n- pnpm -C karakeep --filter @karakeep/web typecheck`n`nCloses #2526 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-03-02 12:00:47 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#2155

No description provided.

Rows
Columns