[PR #2365] [MERGED] fix: Reader settings preview on mobile matches reader view formatting #2085

Closed
opened 2026-03-02 12:00:30 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/2365
Author: @esimkowitz
Created: 1/10/2026
Status: Merged
Merged: 1/18/2026
Merged by: @MohamedBassem

Base: mainHead: reader-settings-preview-mobile


📝 Commits (2)

  • 2f349d1 fix: Reader settings preview on mobile matches reader view formatting
  • daa9d26 address comments

📊 Changes

2 files changed (+170 additions, -16 deletions)

View changed files

📝 apps/mobile/app/dashboard/settings/reader-settings.tsx (+53 -16)
apps/mobile/components/reader/ReaderPreview.tsx (+117 -0)

📄 Description

The reader settings preview on mobile was using a native text element, which has slightly different interpretations of font family/size and line height compared to the Webview used by the reader view. The reader settings preview now uses a pared down Webview with live settings syncing so the previews will actually match the formatting of the reader view.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/2365 **Author:** [@esimkowitz](https://github.com/esimkowitz) **Created:** 1/10/2026 **Status:** ✅ Merged **Merged:** 1/18/2026 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `reader-settings-preview-mobile` --- ### 📝 Commits (2) - [`2f349d1`](https://github.com/karakeep-app/karakeep/commit/2f349d1b4237caa35ae19a07c7f9d8637813c22c) fix: Reader settings preview on mobile matches reader view formatting - [`daa9d26`](https://github.com/karakeep-app/karakeep/commit/daa9d2621cbf179ff15db75d26152618966bca4c) address comments ### 📊 Changes **2 files changed** (+170 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `apps/mobile/app/dashboard/settings/reader-settings.tsx` (+53 -16) ➕ `apps/mobile/components/reader/ReaderPreview.tsx` (+117 -0) </details> ### 📄 Description The reader settings preview on mobile was using a native text element, which has slightly different interpretations of font family/size and line height compared to the Webview used by the reader view. The reader settings preview now uses a pared down Webview with live settings syncing so the previews will actually match the formatting of the reader view. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 12:00:30 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/karakeep#2085
No description provided.