[PR #2281] [MERGED] feat: Add attachedBy field to update tags endpoint #2047

New issue

Closed

opened 2026-03-02 12:00:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 12:00:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/2281
Author: @MohamedBassem
Created: 12/20/2025
Status: ✅ Merged
Merged: 1/18/2026
Merged by: @MohamedBassem

Base: main ← Head: claude/add-attachedby-tags-endpoint-01WYfemMGHJJjXsPYLvUJAno

📝 Commits (6)

f62918e feat: Add attachedBy field to updateTags endpoint
e12c173 fix(cli): migrate bookmark source in migration command
5f0adb6 Merge branch 'main' into claude/add-attachedby-tags-endpoint-01WYfemMGHJJjXsPYLvUJAno
47a2847 fix
a1bdc18 reduce queries
95b6f4f Merge branch 'main' into claude/add-attachedby-tags-endpoint-01WYfemMGHJJjXsPYLvUJAno

📊 Changes

5 files changed (+198 additions, -13 deletions)

View changed files

📝 packages/e2e_tests/tests/api/bookmarks.test.ts (+70 -0)
📝 packages/open-api/karakeep-openapi-spec.json (+16 -0)
📝 packages/shared/types/bookmarks.ts (+2 -1)
📝 packages/trpc/routers/bookmarks.test.ts (+68 -0)
📝 packages/trpc/routers/bookmarks.ts (+42 -12)

📄 Description

This change allows callers to specify the attachedBy field when updating tags on a bookmark. The field defaults to "human" if not provided, maintaining backward compatibility with existing code.

Changes:

Added attachedBy field to zManipulatedTagSchema with default "human"
Updated updateTags endpoint to use the specified attachedBy value
Created mapping logic to correctly assign attachedBy to each tag

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/2281 **Author:** [@MohamedBassem](https://github.com/MohamedBassem) **Created:** 12/20/2025 **Status:** ✅ Merged **Merged:** 1/18/2026 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `claude/add-attachedby-tags-endpoint-01WYfemMGHJJjXsPYLvUJAno` --- ### 📝 Commits (6) - [`f62918e`](https://github.com/karakeep-app/karakeep/commit/f62918e0773334390149ca053e3a8299e3b2210d) feat: Add attachedBy field to updateTags endpoint - [`e12c173`](https://github.com/karakeep-app/karakeep/commit/e12c17310c977563d21bbd30e1e6d5270a1a85db) fix(cli): migrate bookmark source in migration command - [`5f0adb6`](https://github.com/karakeep-app/karakeep/commit/5f0adb6007e955974d6da11192cdc2de5ccb3e5d) Merge branch 'main' into claude/add-attachedby-tags-endpoint-01WYfemMGHJJjXsPYLvUJAno - [`47a2847`](https://github.com/karakeep-app/karakeep/commit/47a2847aa6fb6c798658e1f3f097386fc388f3ab) fix - [`a1bdc18`](https://github.com/karakeep-app/karakeep/commit/a1bdc184da8f163ca6ebdc25d4c17d61fda84737) reduce queries - [`95b6f4f`](https://github.com/karakeep-app/karakeep/commit/95b6f4f97592e5e0f992757b4512253e41de9c11) Merge branch 'main' into claude/add-attachedby-tags-endpoint-01WYfemMGHJJjXsPYLvUJAno ### 📊 Changes **5 files changed** (+198 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `packages/e2e_tests/tests/api/bookmarks.test.ts` (+70 -0) 📝 `packages/open-api/karakeep-openapi-spec.json` (+16 -0) 📝 `packages/shared/types/bookmarks.ts` (+2 -1) 📝 `packages/trpc/routers/bookmarks.test.ts` (+68 -0) 📝 `packages/trpc/routers/bookmarks.ts` (+42 -12) </details> ### 📄 Description This change allows callers to specify the attachedBy field when updating tags on a bookmark. The field defaults to "human" if not provided, maintaining backward compatibility with existing code. Changes: - Added attachedBy field to zManipulatedTagSchema with default "human" - Updated updateTags endpoint to use the specified attachedBy value - Created mapping logic to correctly assign attachedBy to each tag --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 12:00:20 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#2047

No description provided.

Rows
Columns