[PR #2226] [CLOSED] feat: Add loading spinner to ActionButton icon #2028

New issue

Closed

opened 2026-03-02 12:00:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 12:00:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/2226
Author: @MohamedBassem
Created: 12/6/2025
Status: ❌ Closed

Base: main ← Head: claude/actionbutton-loading-spinner-015DY5ZTvgPgFAXTZz3UGaYv

📝 Commits (1)

6248277 feat: add icon prop to ActionButton for better loading UX

📊 Changes

13 files changed (+60 additions, -42 deletions)

View changed files

📝 apps/web/app/settings/assets/page.tsx (+1 -1)
📝 apps/web/app/settings/broken-links/page.tsx (+2 -2)
📝 apps/web/components/dashboard/BulkBookmarksAction.tsx (+2 -3)
📝 apps/web/components/dashboard/bookmarks/ManageListsModal.tsx (+2 -3)
📝 apps/web/components/dashboard/bookmarks/SummarizeBookmarkArea.tsx (+4 -6)
📝 apps/web/components/dashboard/preview/ActionBar.tsx (+4 -6)
📝 apps/web/components/dashboard/rules/RuleEngineRuleList.tsx (+1 -1)
📝 apps/web/components/settings/AISettings.tsx (+3 -3)
📝 apps/web/components/settings/BackupSettings.tsx (+3 -3)
📝 apps/web/components/settings/FeedSettings.tsx (+5 -6)
📝 apps/web/components/settings/WebhookSettings.tsx (+5 -5)
📝 apps/web/components/ui/action-button.tsx (+27 -2)
📝 apps/web/components/ui/markdown/plugins/toolbar-plugin.tsx (+1 -1)

📄 Description

Add optional icon prop to ActionButton component
When loading and icon is provided, spinner replaces icon while text remains
Improves UX by showing context during loading states
Update all ActionButton usages to pass icons explicitly
Maintains backwards compatibility for buttons without icons

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/2226 **Author:** [@MohamedBassem](https://github.com/MohamedBassem) **Created:** 12/6/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `claude/actionbutton-loading-spinner-015DY5ZTvgPgFAXTZz3UGaYv` --- ### 📝 Commits (1) - [`6248277`](https://github.com/karakeep-app/karakeep/commit/62482772a9e93ab5264e4307bc2c3ed2acba5779) feat: add icon prop to ActionButton for better loading UX ### 📊 Changes **13 files changed** (+60 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/app/settings/assets/page.tsx` (+1 -1) 📝 `apps/web/app/settings/broken-links/page.tsx` (+2 -2) 📝 `apps/web/components/dashboard/BulkBookmarksAction.tsx` (+2 -3) 📝 `apps/web/components/dashboard/bookmarks/ManageListsModal.tsx` (+2 -3) 📝 `apps/web/components/dashboard/bookmarks/SummarizeBookmarkArea.tsx` (+4 -6) 📝 `apps/web/components/dashboard/preview/ActionBar.tsx` (+4 -6) 📝 `apps/web/components/dashboard/rules/RuleEngineRuleList.tsx` (+1 -1) 📝 `apps/web/components/settings/AISettings.tsx` (+3 -3) 📝 `apps/web/components/settings/BackupSettings.tsx` (+3 -3) 📝 `apps/web/components/settings/FeedSettings.tsx` (+5 -6) 📝 `apps/web/components/settings/WebhookSettings.tsx` (+5 -5) 📝 `apps/web/components/ui/action-button.tsx` (+27 -2) 📝 `apps/web/components/ui/markdown/plugins/toolbar-plugin.tsx` (+1 -1) </details> ### 📄 Description - Add optional icon prop to ActionButton component - When loading and icon is provided, spinner replaces icon while text remains - Improves UX by showing context during loading states - Update all ActionButton usages to pass icons explicitly - Maintains backwards compatibility for buttons without icons --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 12:00:15 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#2028

No description provided.

Rows
Columns