[PR #2082] [MERGED] fix: Stricter SSRF validation #1968

New issue

Closed

opened 2026-03-02 11:59:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/2082
Author: @MohamedBassem
Created: 11/2/2025
Status: ✅ Merged
Merged: 11/2/2025
Merged by: @MohamedBassem

Base: main ← Head: strict-ssrf-validation

📝 Commits (9)

3548680 fix: Stricter SSRF validation
dca41d3 skip dns resolution if running in proxy context
a9ead0f more fixes
662ac24 Add LRU cache
5f0ced2 change the env variable for internal hostnames
24ab55d make dns resolution timeout configerable
493756f upgrade ipaddr
b6665f7 handle ipv6
a6c5e94 handle proxy bypass for request interceptor

📊 Changes

10 files changed (+602 additions, -135 deletions)

View changed files

➕ apps/workers/network.ts (+419 -0)
📝 apps/workers/package.json (+2 -0)
📝 apps/workers/utils.ts (+0 -61)
📝 apps/workers/workers/crawlerWorker.ts (+54 -27)
📝 apps/workers/workers/feedWorker.ts (+1 -1)
📝 apps/workers/workers/videoWorker.ts (+29 -7)
📝 apps/workers/workers/webhookWorker.ts (+2 -2)
📝 docs/docs/03-configuration.md (+6 -5)
📝 packages/shared/config.ts (+24 -1)
📝 pnpm-lock.yaml (+65 -31)

📄 Description

Mostly implemented by codex.

Will review before merge.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/2082 **Author:** [@MohamedBassem](https://github.com/MohamedBassem) **Created:** 11/2/2025 **Status:** ✅ Merged **Merged:** 11/2/2025 **Merged by:** [@MohamedBassem](https://github.com/MohamedBassem) **Base:** `main` ← **Head:** `strict-ssrf-validation` --- ### 📝 Commits (9) - [`3548680`](https://github.com/karakeep-app/karakeep/commit/3548680ede6ca3072a558b1a5b622d96a766f3fd) fix: Stricter SSRF validation - [`dca41d3`](https://github.com/karakeep-app/karakeep/commit/dca41d37a323f819c017112d7e08bad8923d09ce) skip dns resolution if running in proxy context - [`a9ead0f`](https://github.com/karakeep-app/karakeep/commit/a9ead0f41628cad38133bbd33192f63a3174587c) more fixes - [`662ac24`](https://github.com/karakeep-app/karakeep/commit/662ac249b0162f7ddaa49c5916056a094aa82e93) Add LRU cache - [`5f0ced2`](https://github.com/karakeep-app/karakeep/commit/5f0ced2c6f15c96747302e9185a3d67e569d6dd4) change the env variable for internal hostnames - [`24ab55d`](https://github.com/karakeep-app/karakeep/commit/24ab55d7eaa422f3031444430b564078704024c2) make dns resolution timeout configerable - [`493756f`](https://github.com/karakeep-app/karakeep/commit/493756f3fc76757fa7cdde3131d55bae1c3c55ec) upgrade ipaddr - [`b6665f7`](https://github.com/karakeep-app/karakeep/commit/b6665f7732034772d9a32bc5249ab407408e0e88) handle ipv6 - [`a6c5e94`](https://github.com/karakeep-app/karakeep/commit/a6c5e94a146512da5e99ac8c9b9928dfb96cc96b) handle proxy bypass for request interceptor ### 📊 Changes **10 files changed** (+602 additions, -135 deletions) <details> <summary>View changed files</summary> ➕ `apps/workers/network.ts` (+419 -0) 📝 `apps/workers/package.json` (+2 -0) 📝 `apps/workers/utils.ts` (+0 -61) 📝 `apps/workers/workers/crawlerWorker.ts` (+54 -27) 📝 `apps/workers/workers/feedWorker.ts` (+1 -1) 📝 `apps/workers/workers/videoWorker.ts` (+29 -7) 📝 `apps/workers/workers/webhookWorker.ts` (+2 -2) 📝 `docs/docs/03-configuration.md` (+6 -5) 📝 `packages/shared/config.ts` (+24 -1) 📝 `pnpm-lock.yaml` (+65 -31) </details> ### 📄 Description Mostly implemented by codex. Will review before merge. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:58 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1968

No description provided.

Rows
Columns