[PR #2054] [CLOSED] fix: handle percent encoding in search queries to prevent URIError #1961

New issue

Closed

opened 2026-03-02 11:59:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/2054
Author: @AdrianAcala
Created: 10/18/2025
Status: ❌ Closed

Base: main ← Head: fix/1941-search-percent-crash

📝 Commits (4)

3d35e12 fix: handle percent encoding in search queries to prevent URIError (#1941)
32bc7c4 added docstrings for bookmark-search.ts
f0000ca fix: handle malformed percent encoding in search queries
e0e1ceb Enabled global jest-dom matchers via Vitest setup for the web application

📊 Changes

7 files changed (+501 additions, -29 deletions)

View changed files

➕ apps/web/lib/hooks/__tests__/bookmark-search.test.ts (+159 -0)
📝 apps/web/lib/hooks/bookmark-search.ts (+60 -2)
📝 apps/web/package.json (+3 -0)
📝 apps/web/vitest.config.ts (+4 -0)
➕ apps/web/vitest.setup.ts (+1 -0)
📝 packages/e2e_tests/tests/api/bookmarks.test.ts (+64 -0)
📝 pnpm-lock.yaml (+210 -27)

📄 Description

Add proper error handling for decodeURIComponent in bookmark search hook
Add e2e test to verify searches with % symbols work correctly

Fixes #1941

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/2054 **Author:** [@AdrianAcala](https://github.com/AdrianAcala) **Created:** 10/18/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/1941-search-percent-crash` --- ### 📝 Commits (4) - [`3d35e12`](https://github.com/karakeep-app/karakeep/commit/3d35e1290ed8aa28aa4f25b8bd82ce40c5cdb08a) fix: handle percent encoding in search queries to prevent URIError (#1941) - [`32bc7c4`](https://github.com/karakeep-app/karakeep/commit/32bc7c4da3226aca8f7fcf57800d23c2c6c5035b) added docstrings for bookmark-search.ts - [`f0000ca`](https://github.com/karakeep-app/karakeep/commit/f0000ca41cf197955884b6c282d987091575cbea) fix: handle malformed percent encoding in search queries - [`e0e1ceb`](https://github.com/karakeep-app/karakeep/commit/e0e1ceb6a086f24f72718ba2ad708abf528721fd) Enabled global jest-dom matchers via Vitest setup for the web application ### 📊 Changes **7 files changed** (+501 additions, -29 deletions) <details> <summary>View changed files</summary> ➕ `apps/web/lib/hooks/__tests__/bookmark-search.test.ts` (+159 -0) 📝 `apps/web/lib/hooks/bookmark-search.ts` (+60 -2) 📝 `apps/web/package.json` (+3 -0) 📝 `apps/web/vitest.config.ts` (+4 -0) ➕ `apps/web/vitest.setup.ts` (+1 -0) 📝 `packages/e2e_tests/tests/api/bookmarks.test.ts` (+64 -0) 📝 `pnpm-lock.yaml` (+210 -27) </details> ### 📄 Description - Add proper error handling for decodeURIComponent in bookmark search hook - Add e2e test to verify searches with % symbols work correctly Fixes #1941 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:56 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1961

No description provided.

Rows
Columns