starred/karakeep

Fork 0

mirror of https://github.com/karakeep-app/karakeep.git synced 2026-04-25 07:56:05 +03:00

[PR #1917] [CLOSED] Add edit note button to reader view #1927

New issue

Closed

opened 2026-03-02 11:59:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 11:59:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/karakeep-app/karakeep/pull/1917
Author: @Copilot
Created: 9/8/2025
Status: ❌ Closed

Base: main ← Head: copilot/add-edit-button-for-notes

📝 Commits (2)

0861774 Initial plan
543a33b Add edit note button and modal to reader view

📊 Changes

2 files changed (+113 additions, -0 deletions)

View changed files

📝 apps/web/app/reader/[bookmarkId]/page.tsx (+23 -0)
➕ apps/web/components/dashboard/preview/NoteEditModal.tsx (+90 -0)

📄 Description

This PR adds an "Edit Note" button to the reader view header, allowing users to edit bookmark notes directly without having to navigate back to the list view and use the three-dots menu.

Problem

Previously, users viewing a bookmark in the reader view had no way to edit the associated note. The only way to edit notes was to:

Exit the reader view
Navigate back to the bookmarks list
Find the specific bookmark
Click the three-dots menu
Select "Open Editor"

This was cumbersome and disrupted the reading flow.

Solution

Added an "Edit Note" button (pencil icon) to the reader view header, positioned between the Print and Settings buttons. When clicked, it opens a modal dialog where users can edit the bookmark's note directly.

Changes Made

Created NoteEditModal.tsx: A new modal component that provides a clean interface for editing notes with Save/Cancel functionality
Enhanced reader view: Added the Edit button to the header and integrated the modal component
Consistent UX: Reused existing UI patterns, icons, and styling for seamless integration

Benefits

✅ Improved user experience - no need to leave the reader view to edit notes
✅ Faster workflow - direct access to note editing
✅ Consistent UI - follows existing design patterns
✅ Accessible - includes proper tooltips and keyboard navigation

The implementation reuses existing components and hooks, ensuring consistency with the rest of the application while providing the requested functionality.

Fixes #1913.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

fonts.googleapis.com

Triggering command: node /home/REDACTED/work/karakeep/karakeep/node_modules/.bin/next build --experimental-build-mode compile (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled

Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/karakeep-app/karakeep/pull/1917 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 9/8/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `copilot/add-edit-button-for-notes` --- ### 📝 Commits (2) - [`0861774`](https://github.com/karakeep-app/karakeep/commit/0861774b14d86413b14c05fe2e00a3a098470f85) Initial plan - [`543a33b`](https://github.com/karakeep-app/karakeep/commit/543a33bd86e4a60e6c1edc654b9bdec04cc3ad3a) Add edit note button and modal to reader view ### 📊 Changes **2 files changed** (+113 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `apps/web/app/reader/[bookmarkId]/page.tsx` (+23 -0) ➕ `apps/web/components/dashboard/preview/NoteEditModal.tsx` (+90 -0) </details> ### 📄 Description This PR adds an "Edit Note" button to the reader view header, allowing users to edit bookmark notes directly without having to navigate back to the list view and use the three-dots menu. ## Problem Previously, users viewing a bookmark in the reader view had no way to edit the associated note. The only way to edit notes was to: 1. Exit the reader view 2. Navigate back to the bookmarks list 3. Find the specific bookmark 4. Click the three-dots menu 5. Select "Open Editor" This was cumbersome and disrupted the reading flow. ## Solution Added an "Edit Note" button (pencil icon) to the reader view header, positioned between the Print and Settings buttons. When clicked, it opens a modal dialog where users can edit the bookmark's note directly. ## Changes Made - **Created `NoteEditModal.tsx`**: A new modal component that provides a clean interface for editing notes with Save/Cancel functionality - **Enhanced reader view**: Added the Edit button to the header and integrated the modal component - **Consistent UX**: Reused existing UI patterns, icons, and styling for seamless integration ## Benefits - ✅ Improved user experience - no need to leave the reader view to edit notes - ✅ Faster workflow - direct access to note editing - ✅ Consistent UI - follows existing design patterns - ✅ Accessible - includes proper tooltips and keyboard navigation The implementation reuses existing components and hooks, ensuring consistency with the rest of the application while providing the requested functionality. Fixes #1913. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `fonts.googleapis.com` > - Triggering command: `node /home/REDACTED/work/karakeep/karakeep/node_modules/.bin/next build --experimental-build-mode compile` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/karakeep-app/karakeep/settings/copilot/coding_agent) (admins only) > > </details>  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-02 11:59:47 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-03-02 11:59:48 +03:00

[PR #1927] [CLOSED] Update sameSite options to match currently found values #1930

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/karakeep#1927

No description provided.

Rows
Columns